Rollup of 6 pull requests #82414
Closed
Rollup of 6 pull requests #82414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently `"foo\""` has different behavior from `'foo\''` in Python shlex. See the [discussion on Zulip][z] for more. [z]: https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/.40has.20checks.20.22no.20closing.20quotation.22
Changes from 81473 extended the dead code lint with an ability to detect fields that are written to but never read from. The implementation skips over fields on the left hand side of an assignment, without marking them as live. A field access might involve an automatic dereference and de-facto read the field. Conservatively mark expressions with deref adjustments as live to avoid generating false positive warnings.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Fixes rust-lang#81918 Fixes rust-lang#82326 (duplicate) Fixes rust-lang#82325
Enable smart punctuation Closes rust-lang#76690.
…n-esc, r=Nemo157 Remove query parameters when skipping search results Fixes rust-lang#81330. This PR changes the following: when pressing ESC and that no other "action" was performed (understand: no closing the search result, or hiding a menu or something along the line), then we discard the URL query parameters (the `?whatever=dsjfs`). What do you think about this change `@rust-lang/rustdoc` ? EDIT: finally we're simply removing the query parameter when we're skipping the search results. r? `@Nemo157`
Consider auto derefs before warning about write only fields Changes from rust-lang#81473 extended the dead code lint with an ability to detect fields that are written to but never read from. The implementation skips over fields on the left hand side of an assignment, without marking them as live. A field access might involve an automatic dereference and de-facto read the field. Conservatively mark expressions with deref adjustments as live to avoid generating false positive warnings. Closes rust-lang#81626.
…s, r=jyn514 Jsondocck improvements Adds 2 new commands, ``@is`` and ``@set`.` ``@is`` works like ``@has`,` except instead of checking if any value matches, it checks that there is exactly one value, and it matches. This allows more precise testing. ``@set`` gets a value, and saves it to be used later. This makes it possible to check that an item appears in the correct module. Once this lands, the rest of the test suite can be upgraded to use these. cc `@CraftSpider` `@rustbot` modify labels: +T-rustdoc +A-rustdoc-json +A-testsuite
Fix mir-cfg dumps Fixes rust-lang#81918 Fixes rust-lang#82326 (duplicate) Fixes rust-lang#82325 --- r? `@oli-obk`
disable atomic_max/min tests in Miri Disable some tests that currently [fail in Miri](https://travis-ci.com/github/RalfJung/miri-test-libstd/builds/217788631).
|
@bors: r+ p=6 |
|
📌 Commit 49fca26 has been approved by |
bors
added
the
S-waiting-on-bors
|
Tree was closed earlier so queue has grown plus there are a few rollup=never prs that are waiting for the last few days to be merged :D So closing this, will push more aggressive rollups later :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup