u8::to_string() specialisation (far less asm). #82572
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#73533 pointed out that u8::to_string() was heavy on the codegen: https://rust.godbolt.org/z/1MnhWY
Interestingly whether we use
[0;1]
or[0;4]
(the latter is used for the char specialisation) it seems to make no difference to the generated code.(I tried putting an unstable attribute but apparently it's not effective there so I put a high since value for now. Please point me in the right direction as to how I should put that attribute on?)