Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check stability and feature attributes in rustdoc #82598

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 27, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2021
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

Updated!

@rust-log-analyzer

This comment has been minimized.

src/librustdoc/core.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

src/librustdoc/core.rs Outdated Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member Author

As for the libstd feature, I could only reproduce it locally after updating to last commit so I guess it's a very recent change and it was an incomplete one. Lucky us that we found out this early.

@camelid
Copy link
Member

camelid commented Feb 27, 2021

Heh, I thought the lack of a stability attribute might be an issue! #82420 (comment)

library/std/src/os/mod.rs Outdated Show resolved Hide resolved
@jyn514 jyn514 changed the title Rustdoc rustc pass Check stability and feature attributes in rustdoc Feb 28, 2021
@GuillaumeGomez
Copy link
Member Author

Update the version to 1.35 in both attributes.

@jyn514
Copy link
Member

jyn514 commented Mar 1, 2021

@GuillaumeGomez
Copy link
Member Author

Done as well!

@jyn514
Copy link
Member

jyn514 commented Mar 1, 2021

r=me with CI passing, thanks for fixing this!

@rust-log-analyzer

This comment has been minimized.

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2021
@GuillaumeGomez
Copy link
Member Author

@bors: r=jyn514

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit d20fd62 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2021
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#80734 (check that first arg to `panic!()` in const is `&str`)
 - rust-lang#81932 (Always compile rustdoc with debug logging enabled when `download-rustc` is set)
 - rust-lang#82018 (Remove the dummy cache in `DocContext`; delete RenderInfo)
 - rust-lang#82598 (Check stability and feature attributes in rustdoc)
 - rust-lang#82655 (Highlight identifier span instead of whole pattern span in `unused` lint)
 - rust-lang#82662 (Warn about unknown doc attributes)
 - rust-lang#82676 (Change twice used large const table to static)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5a82251 into rust-lang:master Mar 2, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 2, 2021
@GuillaumeGomez GuillaumeGomez deleted the rustdoc-rustc-pass branch March 2, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc allows multiple declarations of a feature
8 participants