-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check stability and feature attributes in rustdoc #82598
Conversation
This comment has been minimized.
This comment has been minimized.
f8b0113
to
3127a8d
Compare
Updated! |
This comment has been minimized.
This comment has been minimized.
3127a8d
to
b6ebdfa
Compare
This comment has been minimized.
This comment has been minimized.
b6ebdfa
to
7a967c9
Compare
As for the libstd feature, I could only reproduce it locally after updating to last commit so I guess it's a very recent change and it was an incomplete one. Lucky us that we found out this early. |
Heh, I thought the lack of a stability attribute might be an issue! #82420 (comment) |
7a967c9
to
e2c175e
Compare
Update the version to 1.35 in both attributes. |
Thanks. Can you also update https://github.com/rust-lang/rust/blob/e2c175ecdf0207bd34192c292dabd816659b370c/library/std/src/sys/mod.rs#L114 while you're at it? |
e2c175e
to
95dbf0c
Compare
Done as well! |
r=me with CI passing, thanks for fixing this! |
This comment has been minimized.
This comment has been minimized.
95dbf0c
to
8548c47
Compare
8548c47
to
d20fd62
Compare
@bors: r=jyn514 |
📌 Commit d20fd62 has been approved by |
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#80734 (check that first arg to `panic!()` in const is `&str`) - rust-lang#81932 (Always compile rustdoc with debug logging enabled when `download-rustc` is set) - rust-lang#82018 (Remove the dummy cache in `DocContext`; delete RenderInfo) - rust-lang#82598 (Check stability and feature attributes in rustdoc) - rust-lang#82655 (Highlight identifier span instead of whole pattern span in `unused` lint) - rust-lang#82662 (Warn about unknown doc attributes) - rust-lang#82676 (Change twice used large const table to static) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #82588.
cc @Nemo157 @camelid
r? @jyn514