Fix building problems in extra::unicode. #8260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
bors
added a commit
that referenced
this pull request
Aug 4, 2013
WIth this patch `RUSTFLAGS='--cfg unicode' make check"` passed successfully.
* Why doesn't `#[link_name="icuuc"]` make libextra to link against libicuuc.so?
* In `extra::unicode::tests`, `use unicode; unicode::is_foo('a')` failed but `use unicode::*; is_foo('a')` succeeded. Is it right?
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 13, 2022
Downgrade mutex_atomic to nursery See rust-lang#1516 and rust-lang#4295. There are suggestions about removing this lint from the default warned lints in both issues. Also, [`mutex_integer`](https://rust-lang.github.io/rust-clippy/master/index.html#mutex_integer) lint that has the same problems as this lint is in `nursery` group. changelog: Moved [`mutex_atomic`] to `nursery`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIth this patch
RUSTFLAGS='--cfg unicode' make check"passed successfully.#[link_name="icuuc"]make libextra to link against libicuuc.so?extra::unicode::tests,use unicode; unicode::is_foo('a')failed butuse unicode::*; is_foo('a')succeeded. Is it right?