Fix leak in Vec::extend_from_within #82760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously vec's len was updated only after full copy, making the method leak if T::clone panic!s. This commit makes `Vec::extend_from_within` (or, more accurately, it's `T: Clone` specialization) update vec's len on every iteration, fixing the issue. `T: Copy` specialization was not affected by the issue b/c it doesn't call user specified code (as, e.g. `T::clone`), and instead calls `ptr::copy_nonoverlapping`.
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 1f031d9 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
pickfire
reviewed
Mar 24, 2021
|
|
||
| /// Safety: changing returned .2 (&mut usize) is considered the same as calling `.set_len(_)`. | ||
| /// | ||
| /// This method is used to have unique access to all vec parts at once in `extend_from_within`. |
There was a problem hiding this comment.
s/is used to have/provides/ would be clearer
pickfire
reviewed
Mar 24, 2021
pickfire
reviewed
Mar 24, 2021
pickfire
reviewed
Mar 24, 2021
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 18, 2021
…vink Slightly change wording in doc comment and fix typo in vec/mod.rs Suggested by `@pickfire` in rust-lang#82760
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 18, 2021
…vink Slightly change wording in doc comment and fix typo in vec/mod.rs Suggested by ``@pickfire`` in rust-lang#82760
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 18, 2021
…vink Slightly change wording in doc comment and fix typo in vec/mod.rs Suggested by ```@pickfire``` in rust-lang#82760
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2021
Slightly change wording in doc comment and fix typo in vec/mod.rs Suggested by `@pickfire` in rust-lang#82760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82533