Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar Fixes #82888

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Grammar Fixes #82888

merged 2 commits into from
Mar 9, 2021

Conversation

daggy1234
Copy link
Contributor

Found typo's in the array rustdoc. Pr'ed a fix!

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 8, 2021
@daggy1234
Copy link
Contributor Author

@rustbot label +C-enhancement +T-doc

@rustbot rustbot added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Mar 8, 2021
library/core/src/array/mod.rs Outdated Show resolved Hide resolved
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@daggy1234 daggy1234 requested a review from JohnTitor March 8, 2021 14:58
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 8, 2021

📌 Commit 655155c has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2021
Rollup of 11 pull requests

Successful merges:

 - rust-lang#82711 (Add documentation for string->Cow conversions)
 - rust-lang#82767 (Update minifier dependency version)
 - rust-lang#82800 (Move rustdoc UI tests into a subdirectory)
 - rust-lang#82810 (Typo fix in Unstable book: `cargo cov` -> `cargo profdata`)
 - rust-lang#82829 (Handle negative literals in cast overflow warning)
 - rust-lang#82854 (Account for `if (let pat = expr) {}`)
 - rust-lang#82870 (Add note about the `#[doc(no-inline)]` usage)
 - rust-lang#82874 (Add codegen tests for some issues closed by LLVM 12)
 - rust-lang#82881 (diagnostics: Be clear about "crate root" and `::foo` paths in resolve diagnostics)
 - rust-lang#82888 (Grammar Fixes)
 - rust-lang#82897 ([.mailmap] Add entry for Ramkumar Ramachandra)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2d3ba78 into rust-lang:master Mar 9, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants