Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update llvm-project submodule #83030

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Update llvm-project submodule #83030

merged 2 commits into from
Mar 12, 2021

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Mar 11, 2021 •
edited
Loading

Fixes #82833. Fixes #82859. Probably also fixes #83025. This also merges in the current upstream 12.x branch.

r? @nagisa

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2021
@nagisa
Copy link
Member

nagisa commented Mar 11, 2021 •
edited
Loading

Can you please add the test cases from the issues as regression tests (or remove Fixes from the issue description so that the issues don't auto-close and we can remember to add E-needs-test on them).

r=me once either happens.

@nikic
Copy link
Contributor Author

nikic commented Mar 11, 2021

Any suggestion on which ui directory might be suitable for this?

@nagisa
Copy link
Member

nagisa commented Mar 11, 2021 via email

@nikic
Copy link
Contributor Author

nikic commented Mar 11, 2021

I've added tests for two of the issues. I didn't add one for the last one as it's multi-file and the benefit of having a third test for the same issue seems marginal.

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Mar 11, 2021

📌 Commit ef269ac has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2021
@nagisa
Copy link
Member

nagisa commented Mar 12, 2021

@bors p=1 fixes somewhat serious soundness issues.

@bors
Copy link
Contributor

bors commented Mar 12, 2021

⌛ Testing commit ef269ac with merge 215ebc3...

@bors
Copy link
Contributor

bors commented Mar 12, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 215ebc3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 12, 2021
@bors bors merged commit 215ebc3 into rust-lang:master Mar 12, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 12, 2021
@io12 io12 mentioned this pull request Mar 13, 2021
Closed
@nagisa nagisa mentioned this pull request Mar 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
5 participants
@nikic @rust-highfive @nagisa @bors @rustbot