Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix const stability since versions. #83053

Merged
merged 1 commit into from
Mar 21, 2021
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 12, 2021

fixes #82085

r? @m-ou-se

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Mar 13, 2021

Thanks!

I've checked them all, and I think these four are still incorrect:

And I think the ones for AtomicUsize::new, AtomicIsize:new also need to be modified (to 1.24 I think?).

@m-ou-se m-ou-se added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2021
@oli-obk oli-obk force-pushed the const_stab_version branch from d25fca1 to 6f3635d Compare March 15, 2021 14:39
@oli-obk oli-obk added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 15, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Mar 21, 2021

Thank you!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 21, 2021

📌 Commit 6f3635d has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2021
@bors
Copy link
Contributor

bors commented Mar 21, 2021

⌛ Testing commit 6f3635d with merge f826641...

@bors
Copy link
Contributor

bors commented Mar 21, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing f826641 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 21, 2021
@bors bors merged commit f826641 into rust-lang:master Mar 21, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 21, 2021
@oli-obk oli-obk deleted the const_stab_version branch March 22, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

str::as_bytes and friends have incorrect const stabilization version annotation
5 participants