-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterate on crate_inherent_impls for metadata. #83082
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ab17829 with merge f385c2df516c51b489279617f62ac9e6d3247628... |
☀️ Try build successful - checks-actions |
Queued f385c2df516c51b489279617f62ac9e6d3247628 with parent 178bd91, future comparison URL. |
Finished benchmarking try commit (f385c2df516c51b489279617f62ac9e6d3247628): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Huh... this regresses rustdoc? Idk how rustdoc handles metadata, but that seems very odd. Should we ping the rustdoc team? |
TBH, all the differences are <1%, so I barely looked at them. |
Yea... I'm fine regressing rustdoc a bit, but it would still be nice to track it, since it seems like a symptom of a deeper thing (I don't think this PR should affect rustdoc, and the fact that it does speaks for rustdoc doing something odd) @bors r+ |
📌 Commit ab17829 has been approved by |
☀️ Test successful - checks-actions |
Split from #80347
r? @oli-obk