-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PR 81473 to resolve (on beta) issues 81626 and 81658. #83171
Revert PR 81473 to resolve (on beta) issues 81626 and 81658. #83171
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
|
As noted in my comment on 81473, this was discussed in last weeks compiler triage meeting, where the team decided to revert this on beta (alone). Therefore, I am unilaterally beta-nominating and immediately tagging as beta-accepted. |
@bors r+ rollup=never I think if this is not yet patched on master (I'm not sure), we'll want to apply the revert on master as well - otherwise we'll need to redo this for next beta presumably, which branches tomorrow. |
📌 Commit 71e57ad has been approved by |
☀️ Test successful - checks-actions |
…imulacrum [stable] 1.52.0 release This includes the release notes (rust-lang#84183) as well as cherry-picked commits from: * [beta] revert PR rust-lang#77885 rust-lang#84710 * [beta] remove assert_matches rust-lang#84759 * Revert PR 81473 to resolve (on beta) issues 81626 and 81658. rust-lang#83171 * [beta] rustdoc revert deref recur rust-lang#84868 * Fix ICE of for-loop mut borrowck where no suggestions are available rust-lang#83401 Additionally in "fresh work" we're also: * reverting: directly expose copy and copy_nonoverlapping intrinsics rust-lang#81238 to avoid rust-lang#84297 on 1.52
…crum [beta] Prepare beta 1.53.0 Along with updating the channel and updating the bootstrap compiler, this also includes: * 692454d - Fixes the diagnostics difference we had for some cycles already * 9157430 - Disables the known broken RLS builder on AArch64 Windows * rust-lang#84183 - Update RELEASES.md for 1.52.0 * rust-lang#84950 - Revert PR 83866 * rust-lang#84886 - Update RLS and Rustfmt Changes we backported to 1.52.0 that we also need to include in 1.53.0 to avoid regressing: * rust-lang#84867 - rustdoc: revert deref recur to resume inclusion of impl ExtTrait<Local> for ExtType * rust-lang#84759 - [beta] remove assert_matches * rust-lang#83171 - Revert PR 81473 to resolve (on beta) issues 81626 and 81658. r? `@ghost`
…473-warn-write-only-fields, r=simulacrum Revert PR 81473 to resolve (on mainline) issues 81626 and 81658. This is a nightly-targetted variant of PR rust-lang#83171 The intent is to just address issue rust-lang#81658 on all release channels, rather that keep repeatedly reverting PR rust-lang#83171 on beta. However, our intent is *also* to reland PR rust-lang#83171 after we have addressed issue rust-lang#81658 , most likely by coupling the re-landing of PR rust-lang#83171 with an enhancement like PR rust-lang#83004
Revert PR #81473 to resolve (on beta) issues #81626 and #81658.
Revert "Add missing brace"
This reverts commit 85ad773.
Revert "Simplify base_expr"
This reverts commit 899aae4.
Revert "Warn write-only fields"
This reverts commit d3c69a4.