Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #83178

Closed
wants to merge 43 commits into from

Commits on Feb 21, 2021

  1. run-make: Specify --target to rustc

    Resolves rust-lang#78911
    
    The target's linker was used but rustc wasn't told to build for that
    target (instead defaulting to the host). This led to the host instead of
    the target getting tested and to the linker getting inappropriate
    arguments.
    tblah committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    2f7672f View commit details
    Browse the repository at this point in the history
  2. run-make: skip issue-36710 on riscv64

    The test assumes it can run target binaries on the host. This not true
    for riscv64 CI (or for other platforms using remote-test-server).
    tblah committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    1b55654 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f69d954 View commit details
    Browse the repository at this point in the history
  4. bootstrap: don't run linkcheck when crosscompiling

    When we cross compile, some things (and their documentation) are built
    for the host (e.g. rustc), while others (and their documentation) are built
    for the target. This generated documentation will have broken links
    between documentation for different platforms e.g. between rustc and
    cargo.
    tblah committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    b71573b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9b23df1 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. Update Vec docs

    henrytheswimmer authored Mar 13, 2021
    Configuration menu
    Copy the full SHA
    81d1d82 View commit details
    Browse the repository at this point in the history
  2. Get rid of the garbage produced by getObjectFromId

    There is no reason for this function to return an object,
    since it is always used for getting at the name anyhow.
    It's used in the inner loop for some popular functions,
    so we want to avoid allocating in it.
    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    5fe3b87 View commit details
    Browse the repository at this point in the history
  3. In checkGenerics and checkType, don't use Array.prototype.splice so much

    Every time splice() is called, another temporary object is created.
    This version, which uses plain objects as a sort of Hash Bag,
    should only produce one temporary object each time it's called.
    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    d7971e5 View commit details
    Browse the repository at this point in the history
  4. Eagerly generate the underscore-less name to search on

    Basically, it doesn't make sense to generate those things every time
    you search. That generates a bunch of stuff for the GC to clean up,
    when, if the user wanted to do another search, it would just need
    to re-do it again.
    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    3f70bfa View commit details
    Browse the repository at this point in the history
  5. Update src/librustdoc/html/static/main.js

    Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
    notriddle and GuillaumeGomez authored Mar 13, 2021
    Configuration menu
    Copy the full SHA
    b76a3d3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ca04ce3 View commit details
    Browse the repository at this point in the history
  7. Fix jslint warnings

    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    b7d14b1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7834aeb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    26f85cc View commit details
    Browse the repository at this point in the history
  10. Remove tab character

    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    d92f840 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    fa3694f View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Avoid generating new strings for names that have no undescores

    This should have negligible effect on time, but it cuts about 1MiB
    off of resident memory usage.
    notriddle committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    0bfd142 View commit details
    Browse the repository at this point in the history
  2. Use a number for row.id, instead of a string

    There's no reason for it to be a string, since it's only used for
    de-duplicating the results arrays anyhow.
    notriddle committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    f57d715 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3612953 View commit details
    Browse the repository at this point in the history
  4. Remove dead code.

    cjgillot committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    17d3308 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e8b2e7b View commit details
    Browse the repository at this point in the history
  6. Make nameWithoutUndescores lowercased

    This basically fixes a search bug introduced by earlier changes.
    notriddle committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    8eba927 View commit details
    Browse the repository at this point in the history
  7. Address review comments

    Amanieu committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    ba00ddc View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Fall-back to sans-serif if Arial is not available

    Otherwise on systems where Arial is not available the system will
    fallback to a serif font, rather than a sans-serif one.
    
    This is especially relevant on acessibility-conscious setups (such as is
    mine) that have web-fonts disabled and a limited set of fonts available
    on the system.
    nagisa committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    7134b0e View commit details
    Browse the repository at this point in the history
  2. No background for code in portability snippets

    This better matches the appearance of this kind of snippet in the full
    item view and is less jarring to read due to repeated
    foreground-background changes.
    nagisa committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    9aa48ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db14627 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dcba95f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e66e9d View commit details
    Browse the repository at this point in the history
  6. Specify *.woff2 files as binary

    This prevents older git versions to change the "line endings".
    jfrimmel committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    ff8717b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    924e522 View commit details
    Browse the repository at this point in the history
  8. Extend proc_macro_back_compat lint to procedural-masquerade

    We now lint on *any* use of `procedural-masquerade` crate. While this
    crate still exists, its main reverse dependency (`cssparser`) no longer
    depends on it. Any crates still depending off should stop doing so, as
    it only exists to support very old Rust versions.
    
    If a crate actually needs to support old versions of rustc via
    `procedural-masquerade`, then they'll just need to accept the warning
    until we remove it entirely (at the same time as the back-compat hack).
    The latest version of `procedural-masquerade` does not work with the
    latest rustc, but trying to check for the version seems like more
    trouble than it's worth.
    
    While working on this, I realized that the `proc-macro-hack` check was
    never actually doing anything. The corresponding enum variant in
    `proc-macro-hack` is named `Value` or `Nested` - it has never been
    called `Input`. Due to a strange Crater issue, the Crater run that
    tested adding this did *not* end up testing it - some of the crates that
    would have failed did not actually have their tests checked, making it
    seem as though the `proc-macro-hack` check was working.
    
    The Crater issue is being discussed at
    https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Nearly.20identical.20Crater.20runs.20processed.20a.20crate.20differently/near/230406661
    
    Despite the `proc-macro-hack` check not actually doing anything, we
    haven't gotten any reports from users about their build being broken.
    I went ahead and removed it entirely, since it's clear that no one is
    being affected by the `proc-macro-hack` regression in practice.
    Aaron1011 committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    d6a7c1d View commit details
    Browse the repository at this point in the history
  9. Update clippy tests

    petrochenkov committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    e98b7d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Rollup merge of rust-lang#80839 - tblah:riscv64linux_links, r=sanxiyn

    Riscv64linux Test fixes
    
    Get tests passing again using the riscv64gc-unknown-linux-gnu docker image.
    
    Test with
    ```
    src/ci/docker/run.sh riscv64gc-linux
    ```
    
    ## linkcheck
    Linkcheck tests that interdocument links in the documentation are correct. Some interdocument links go between rustc and tools (such as rustdoc and cargo). When cross compiling, rustc is built for the host while some tools are built for the target. This goes for the documentation too. Because of this, links in the rustc documentation reffering to cargo or rustdoc documentation look broken.
    
    This issue is worked around by disabling linkcheck for cross compilation builds.
    
    ## run-make tests
    
    rust-lang#78911 seems to happen because `--target` was not passed to `rustc`, but the target linker was specified, causing the target linker to be called with options intended for the host.
    
    Resolves rust-lang#78911
    
    In a separate issue, `issue-36710` was trying to run a binary built for the target on the host system. This will not work for any platform using `remote-test-server`/`client` (such as riscv64). I don't know of a way of skipping those platforms specifically, so I set this test to skip only on riscv64 for now.
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    142028e View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#82838 - Amanieu:rustdoc_asm, r=nagisa

    Allow rustdoc to handle asm! of foreign architectures
    
    This allows rustdoc to process code containing `asm!` for architectures other than the current one. Since this never reaches codegen, we just replace target-specific registers and register classes with a dummy one.
    
    Fixes rust-lang#82869
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    d0222f1 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#83072 - henryboisdequin:patch-1, r=Dylan-DPC

    Update `Vec` docs
    
    Fix typos/nits in `Vec` docs
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    0e7ab5a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#83077 - notriddle:gc-cleanup-rustdoc-search…

    …, r=GuillaumeGomez
    
    rustdoc: reduce GC work during search
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    a9d6f8a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#83092 - petrochenkov:qspan, r=estebank

    More precise spans for HIR paths
    
    `Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path.
    This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span.
    
    This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans).
    r? ``@estebank``
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    c73d157 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#83124 - cjgillot:iiib, r=petrochenkov

    Do not insert impl_trait_in_bindings opaque definitions twice.
    
    The reference to the item already appears inside the `OpaqueDef`. It does not need to be repeated as a statement.
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    dba97da View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#83156 - nagisa:nagisa/sans-serif-please, r=…

    …GuillaumeGomez
    
    Fall-back to sans-serif if Arial is not available
    
    Otherwise on systems where Arial is not available the UA will
    fallback to a serif font, rather than a sans-serif one.
    
    This is especially relevant on acessibility-conscious setups (such as is
    mine) that have web-fonts disabled and a limited set of fonts available
    on the system.
    
    r? ``@GuillaumeGomez`` cc ``@jsha``
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    0463c76 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#83157 - nagisa:nagisa/portability-backgroun…

    …d, r=GuillaumeGomez
    
    No background for code in portability snippets
    
    This better matches the appearance of this kind of snippet in the full
    item view and is less jarring to read due to repeated
    foreground-background changes.
    
    ![Listing of items in a module with some portability snippets attached to some of the items (light theme). The portability snippet has a light blue background and all of the text in it, monospace or not, is the same colour – black](https://user-images.githubusercontent.com/679122/111196363-1900f500-85b5-11eb-8f97-e283c59002a4.png)
    ![Listing of items in a module with some portability snippets attached to some of the items (dark theme). The portability snippet has a light blue background and all of the text in it, monospace or not, is the same colour – black](https://user-images.githubusercontent.com/679122/111196366-19998b80-85b5-11eb-9914-4d14d9d13ed3.png)
    
    There should be no observable changes to the ayu theme.
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    afcd0a6 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#83160 - m-ou-se:deprecate-rustc-serialize-d…

    …erives, r=petrochenkov
    
    Deprecate RustcEncodable and RustcDecodable.
    
    We can't remove the `RustcEncodable` and `RustcDecodable` derive macros from the prelude, but we can deprecate them.
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    1a513c4 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#83162 - jfrimmel:woff2, r=Mark-Simulacrum

    Specify *.woff2 files as binary
    
    This prevents older git versions to change the "line endings".
    Fixes rust-lang#83159.
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    4e39084 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#83168 - Aaron1011:lint-procedural-masquerad…

    …e, r=petrochenkov
    
    Extend `proc_macro_back_compat` lint to `procedural-masquerade`
    
    We now lint on *any* use of `procedural-masquerade` crate. While this
    crate still exists, its main reverse dependency (`cssparser`) no longer
    depends on it. Any crates still depending off should stop doing so, as
    it only exists to support very old Rust versions.
    
    If a crate actually needs to support old versions of rustc via
    `procedural-masquerade`, then they'll just need to accept the warning
    until we remove it entirely (at the same time as the back-compat hack).
    The latest version of `procedural-masquerade` does not work with the
    latest rustc, but trying to check for the version seems like more
    trouble than it's worth.
    
    While working on this, I realized that the `proc-macro-hack` check was
    never actually doing anything. The corresponding enum variant in
    `proc-macro-hack` is named `Value` or `Nested` - it has never been
    called `Input`. Due to a strange Crater issue, the Crater run that
    tested adding this did *not* end up testing it - some of the crates that
    would have failed did not actually have their tests checked, making it
    seem as though the `proc-macro-hack` check was working.
    
    The Crater issue is being discussed at
    https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Nearly.20identical.20Crater.20runs.20processed.20a.20crate.20differently/near/230406661
    
    Despite the `proc-macro-hack` check not actually doing anything, we
    haven't gotten any reports from users about their build being broken.
    I went ahead and removed it entirely, since it's clear that no one is
    being affected by the `proc-macro-hack` regression in practice.
    Dylan-DPC authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    1c3860b View commit details
    Browse the repository at this point in the history