Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #83199

Merged
merged 36 commits into from
Mar 16, 2021
Merged

Rollup of 10 pull requests #83199

merged 36 commits into from
Mar 16, 2021

Commits on Feb 6, 2021

  1. Added try_exists() method to std::path::Path

    This method is similar to the existing `exists()` method, except it
    doesn't silently ignore the errors, leading to less error-prone code.
    
    This change intentionally does NOT touch the documentation of `exists()`
    nor recommend people to use this method while it's unstable.
    Such changes are reserved for stabilization to prevent confusing people.
    
    Apart from that it avoids conflicts with rust-lang#80979.
    Kixunil committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    66f7f7d View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. Update Vec docs

    henrytheswimmer authored Mar 13, 2021
    Configuration menu
    Copy the full SHA
    81d1d82 View commit details
    Browse the repository at this point in the history
  2. Get rid of the garbage produced by getObjectFromId

    There is no reason for this function to return an object,
    since it is always used for getting at the name anyhow.
    It's used in the inner loop for some popular functions,
    so we want to avoid allocating in it.
    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    5fe3b87 View commit details
    Browse the repository at this point in the history
  3. In checkGenerics and checkType, don't use Array.prototype.splice so much

    Every time splice() is called, another temporary object is created.
    This version, which uses plain objects as a sort of Hash Bag,
    should only produce one temporary object each time it's called.
    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    d7971e5 View commit details
    Browse the repository at this point in the history
  4. Eagerly generate the underscore-less name to search on

    Basically, it doesn't make sense to generate those things every time
    you search. That generates a bunch of stuff for the GC to clean up,
    when, if the user wanted to do another search, it would just need
    to re-do it again.
    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    3f70bfa View commit details
    Browse the repository at this point in the history
  5. Update src/librustdoc/html/static/main.js

    Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
    notriddle and GuillaumeGomez authored Mar 13, 2021
    Configuration menu
    Copy the full SHA
    b76a3d3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ca04ce3 View commit details
    Browse the repository at this point in the history
  7. Fix jslint warnings

    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    b7d14b1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7834aeb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    26f85cc View commit details
    Browse the repository at this point in the history
  10. Remove tab character

    notriddle committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    d92f840 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Avoid generating new strings for names that have no undescores

    This should have negligible effect on time, but it cuts about 1MiB
    off of resident memory usage.
    notriddle committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    0bfd142 View commit details
    Browse the repository at this point in the history
  2. Use a number for row.id, instead of a string

    There's no reason for it to be a string, since it's only used for
    de-duplicating the results arrays anyhow.
    notriddle committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    f57d715 View commit details
    Browse the repository at this point in the history
  3. Make nameWithoutUndescores lowercased

    This basically fixes a search bug introduced by earlier changes.
    notriddle committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    8eba927 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Fall-back to sans-serif if Arial is not available

    Otherwise on systems where Arial is not available the system will
    fallback to a serif font, rather than a sans-serif one.
    
    This is especially relevant on acessibility-conscious setups (such as is
    mine) that have web-fonts disabled and a limited set of fonts available
    on the system.
    nagisa committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    7134b0e View commit details
    Browse the repository at this point in the history
  2. No background for code in portability snippets

    This better matches the appearance of this kind of snippet in the full
    item view and is less jarring to read due to repeated
    foreground-background changes.
    nagisa committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    9aa48ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dcba95f View commit details
    Browse the repository at this point in the history
  4. Specify *.woff2 files as binary

    This prevents older git versions to change the "line endings".
    jfrimmel committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    ff8717b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    924e522 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    62cf244 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    64e2248 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    45988ee View commit details
    Browse the repository at this point in the history
  9. Constify mem::transmute_copy

    usbalbin committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    db9a53b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Use delay_span_bug instead of panic in layout_scalar_valid_range

    83054 introduced validation of scalar range attributes, but panicking
    code that uses the attribute remained reachable. Use `delay_span_bug`
    instead to avoid the ICE.
    tmiasko committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    335427a View commit details
    Browse the repository at this point in the history
  2. Make bootstrap be more informative when one does x.py test on a bet…

    …a checkout without other mods.
    
    To be clear, by default running `x.py test` on a checkout of the beta branch
    currently fails, and with this change will continue to fail, because `x.py
    tests` runs `x.py test src/tools/tidy` which tries to run `rustfmt` and that
    will fail because the `rustfmt` binary is pinned to the current nighlty and we
    do not attempt to distribute one for the beta builds.
    
    This change gives a better error message than the current message, which is just
    "./x.py fmt is not supported on this channel" without providing any hint about
    what one might do about that problem.
    
    (update: placated tidy.)
    pnkfelix committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    d6de60f View commit details
    Browse the repository at this point in the history
  3. Filled tracking issue for path_try_exists

    This adds the ID of the tracking issue to the feature.
    Kixunil committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    4330268 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#81822 - Kixunil:path_try_exists, r=kennytm

    Added `try_exists()` method to `std::path::Path`
    
    This method is similar to the existing `exists()` method, except it
    doesn't silently ignore the errors, leading to less error-prone code.
    
    This change intentionally does NOT touch the documentation of `exists()`
    nor recommend people to use this method while it's unstable.
    Such changes are reserved for stabilization to prevent confusing people.
    
    Apart from that it avoids conflicts with rust-lang#80979.
    
    `@joshtriplett` requested this PR in [internals discussion](https://internals.rust-lang.org/t/the-api-of-path-exists-encourages-broken-code/13817/25?u=kixunil)
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    62d38da View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#83072 - henryboisdequin:patch-1, r=Dylan-DPC

    Update `Vec` docs
    
    Fix typos/nits in `Vec` docs
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b6df781 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#83077 - notriddle:gc-cleanup-rustdoc-search…

    …, r=GuillaumeGomez
    
    rustdoc: reduce GC work during search
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    dbdb2a1 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#83091 - usbalbin:const_copy, r=oli-obk

    Constify `copy` related functions
    
    Constify
    
    * `*const T::copy_to[_nonoverlapping]`
    * `*mut T::copy_to[_nonoverlapping]`
    * `*mut T::copy_from[_nonoverlapping]`
    * `mem::transmute_copy`
    * `mem::swap`
    * `ptr::swap[_nonoverlapping]`
    * `mem::replace`
    * `ptr::replace`
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    d3460cd View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#83156 - nagisa:nagisa/sans-serif-please, r=…

    …GuillaumeGomez
    
    Fall-back to sans-serif if Arial is not available
    
    Otherwise on systems where Arial is not available the UA will
    fallback to a serif font, rather than a sans-serif one.
    
    This is especially relevant on acessibility-conscious setups (such as is
    mine) that have web-fonts disabled and a limited set of fonts available
    on the system.
    
    r? ```@GuillaumeGomez``` cc ```@jsha```
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    0f6b206 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#83157 - nagisa:nagisa/portability-backgroun…

    …d, r=GuillaumeGomez
    
    No background for code in portability snippets
    
    This better matches the appearance of this kind of snippet in the full
    item view and is less jarring to read due to repeated
    foreground-background changes.
    
    ![Listing of items in a module with some portability snippets attached to some of the items (light theme). The portability snippet has a light blue background and all of the text in it, monospace or not, is the same colour – black](https://user-images.githubusercontent.com/679122/111196363-1900f500-85b5-11eb-8f97-e283c59002a4.png)
    ![Listing of items in a module with some portability snippets attached to some of the items (dark theme). The portability snippet has a light blue background and all of the text in it, monospace or not, is the same colour – black](https://user-images.githubusercontent.com/679122/111196366-19998b80-85b5-11eb-9914-4d14d9d13ed3.png)
    
    There should be no observable changes to the ayu theme.
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    896b44a View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#83160 - m-ou-se:deprecate-rustc-serialize-d…

    …erives, r=petrochenkov
    
    Deprecate RustcEncodable and RustcDecodable.
    
    We can't remove the `RustcEncodable` and `RustcDecodable` derive macros from the prelude, but we can deprecate them.
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    39af66f View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#83162 - jfrimmel:woff2, r=Mark-Simulacrum

    Specify *.woff2 files as binary
    
    This prevents older git versions to change the "line endings".
    Fixes rust-lang#83159.
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    70bacd6 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#83172 - pnkfelix:bootstrap-tell-me-what-to-…

    …do-about-tidy-on-beta, r=Mark-Simulacrum
    
    More informative diagnotic from `x.py test` attempt atop beta checkout
    
    Make bootstrap be more informative when one does `x.py test` on a beta checkout without other mods.
    
    To be clear, by default running `x.py test` on a checkout of the beta branch
    currently fails, and with this change will continue to fail, because `x.py
    tests` runs `x.py test src/tools/tidy` which tries to run `rustfmt` and that
    will fail because the `rustfmt` binary is pinned to the current nighlty and we
    do not attempt to distribute one for the beta builds.
    
    This change gives a better error message than the current message, which is just
    "./x.py fmt is not supported on this channel" without providing any hint about
    what one might do about that problem.
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b62997f View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#83196 - tmiasko:valid-range-delay-span-bug,…

    … r=oli-obk
    
    Use delay_span_bug instead of panic in layout_scalar_valid_range
    
    rust-lang#83054 introduced validation of scalar range attributes, but panicking
    code that uses the attribute remained reachable. Use `delay_span_bug`
    instead to avoid the ICE.
    
    Fixes rust-lang#83180.
    JohnTitor authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    ec07427 View commit details
    Browse the repository at this point in the history