Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug-print result when an unstable fingerprint is detected #83314

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

Aaron1011
Copy link
Member

Helps with issues like #83311

I had previously tried to do this in #80692, but it had a significant performance impact (even though the code was never actually run). Hopefully, this will be better now that #79100 has been merged.

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 20, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 20, 2021
@bors
Copy link
Contributor

bors commented Mar 20, 2021

⌛ Trying commit 443cef5 with merge 42a82e0e789fcafa494356e56cfe095c3309f6f6...

@bors
Copy link
Contributor

bors commented Mar 20, 2021

☀️ Try build successful - checks-actions
Build commit: 42a82e0e789fcafa494356e56cfe095c3309f6f6 (42a82e0e789fcafa494356e56cfe095c3309f6f6)

@rust-timer
Copy link
Collaborator

Queued 42a82e0e789fcafa494356e56cfe095c3309f6f6 with parent f5f33ec, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (42a82e0e789fcafa494356e56cfe095c3309f6f6): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@lcnr
Copy link
Contributor

lcnr commented Mar 20, 2021

this actually looks like a small perf improvement?

well, i guess as it isn't a regression:
@bors r+

@bors
Copy link
Contributor

bors commented Mar 20, 2021

📌 Commit 443cef5 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2021
@bors
Copy link
Contributor

bors commented Mar 20, 2021

⌛ Testing commit 443cef5 with merge 61edfd5...

@bors
Copy link
Contributor

bors commented Mar 20, 2021

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 61edfd5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 20, 2021
@bors bors merged commit 61edfd5 into rust-lang:master Mar 20, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 20, 2021
@klensy
Copy link
Contributor

klensy commented Mar 20, 2021

this actually looks like a small perf improvement?

But how it can be improvement, if there only thing changed is added new string for format! output? Strange.

@Aaron1011
Copy link
Member Author

Yeah, the performance improvement is quite odd. Maybe the additional code we generate causes LLVM to decide to not inline something, which ends up improving performance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants