Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strong_count mutation methods to Rc #83476

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Add strong_count mutation methods to Rc #83476

merged 1 commit into from
Apr 7, 2021

Conversation

mystor
Copy link
Contributor

@mystor mystor commented Mar 25, 2021

The corresponding methods were stabilized on Arc in #79285 (tracking: #71983). This patch implements and stabilizes identical methods on the Rc types as well.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2021
@m-ou-se m-ou-se assigned m-ou-se and unassigned kennytm Mar 25, 2021
@m-ou-se m-ou-se added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 25, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Mar 25, 2021

@rfcbot merge

This adds Rc::{increment_strong_count, decrement_strong_count}. In the stabilization PR for the same methods on Arc, these Rc equivalents were mentioned as a follow up.

@rfcbot
Copy link

rfcbot commented Mar 25, 2021 •
edited by dtolnay
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Mar 25, 2021
@kennytm kennytm added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2021
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Mar 25, 2021
@rfcbot
Copy link

rfcbot commented Mar 25, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@kennytm kennytm added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Mar 26, 2021
@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Apr 4, 2021
@rfcbot
Copy link

rfcbot commented Apr 4, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 4, 2021
@kennytm kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 7, 2021
@kennytm
Copy link
Member

kennytm commented Apr 7, 2021

@bors r=m-ou-se

@bors
Copy link
Contributor

bors commented Apr 7, 2021

📌 Commit a591d7a has been approved by m-ou-se

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 7, 2021
@kennytm
Copy link
Member

kennytm commented Apr 7, 2021

@bors rollup

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 7, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2021
@bors
Auto merge of rust-lang#83964 - Dylan-DPC:rollup-9kinaiv, r=Dylan-DPC
e9cdccc 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#83476 (Add strong_count mutation methods to Rc)
 - rust-lang#83634 (Do not emit the advanced diagnostics on macros)
 - rust-lang#83816 (Trigger `unused_doc_comments` on macros at once)
 - rust-lang#83916 (Use AnonConst for asm! constants)
 - rust-lang#83935 (forbid `impl Trait` in generic param defaults)
 - rust-lang#83936 (Disable using non-ascii identifiers in extern blocks.)
 - rust-lang#83945 (Add suggestion to reborrow mutable references when they're moved in a for loop)
 - rust-lang#83954 (Do not ICE when closure is involved in Trait Alias Impl Trait)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 505846e into rust-lang:master Apr 7, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 7, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 8, 2021
@sdroege sdroege mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
8 participants
@mystor @rust-highfive @m-ou-se @rfcbot @kennytm @bors @apiraino @rustbot