Properly suggest deref in else block #83489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
camelid
added
A-diagnostics
LeSeulArtichaut
force-pushed
the
deref-else
branch
from
2a9dc08 to
1452875
Compare
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
deref-else
branch
from
1452875 to
8d1c4f4
Compare
davidtwco
requested changes
Mar 26, 2021
davidtwco
added
S-waiting-on-author
LingMan
reviewed
Mar 27, 2021
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
deref-else
branch
from
e1690cd to
353ff51
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Léo Lanteri Thauvin <leseulartichaut@gmail.com>
Co-authored-by: Camelid <camelidcamel@gmail.com>
LeSeulArtichaut
force-pushed
the
deref-else
branch
from
353ff51 to
9c1235f
Compare
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
deref-else
branch
from
9c1235f to
35e0093
Compare
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
deref-else
branch
from
35e0093 to
fb7cf09
Compare
LeSeulArtichaut
added
S-waiting-on-review
davidtwco
approved these changes
Apr 5, 2021
|
@bors r+ |
|
📌 Commit fb7cf09 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#83370 (Add `x.py setup tools` which enables `download-rustc` by default) - rust-lang#83489 (Properly suggest deref in else block) - rust-lang#83734 (Catch a bad placeholder type error for statics in `extern`s) - rust-lang#83814 (expand: Do not ICE when a legacy AST-based macro attribute produces and empty expression) - rust-lang#83835 (rustdoc: sort search index items for compression) - rust-lang#83849 (rustdoc: Cleanup handling of associated items for intra-doc links) - rust-lang#83881 (:arrow_up: rust-analyzer) - rust-lang#83885 (Document compiler/ with -Aprivate-intra-doc-links) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #79755, fixes #79736
r? @davidtwco