Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fs error open_from unix #83522

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Improve fs error open_from unix #83522

merged 1 commit into from
Mar 27, 2021

Conversation

pickfire
Copy link
Contributor

Consistency for #79399
Suggested by JohnTitor

r? @JohnTitor

Not user if the error is too long now, do we handle long errors well?

@pickfire
Copy link
Contributor Author

One other place we could improve is

/// A parameter was incorrect.
which are the docs for InvalidInput, but that is being used by quite a few different components, so not sure how to improve that even.

@JohnTitor JohnTitor self-assigned this Mar 27, 2021
library/std/src/sys/unix/fs.rs Outdated Show resolved Hide resolved
library/std/src/sys_common/fs.rs Outdated Show resolved Hide resolved
@JohnTitor
Copy link
Member

r=me once nits are addressed and commits are squashed.

@JohnTitor JohnTitor added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 27, 2021
@rust-log-analyzer

This comment has been minimized.

Consistency for rust-lang#79399
Suggested by JohnTitor

Improve fs error invaild input for sys_common

The text was duplicated from unix.
@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 27, 2021

📌 Commit 6c6ef73 has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 27, 2021
@pickfire
Copy link
Contributor Author

@JohnTitor Note that I change the code to import from sys_common.

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#81351 (combine: stop eagerly evaluating consts)
 - rust-lang#82525 (make unaligned_references future-incompat lint warn-by-default)
 - rust-lang#82626 (update array missing `IntoIterator` msg)
 - rust-lang#82917 (Add function core::iter::zip)
 - rust-lang#82993 (rustdoc: Use diagnostics for error when including sources)
 - rust-lang#83522 (Improve fs error open_from unix)
 - rust-lang#83548 (Always preserve `None`-delimited groups in a captured `TokenStream`)
 - rust-lang#83555 (Add #[inline] to io::Error methods)

Failed merges:

 - rust-lang#83130 (escape_ascii take 2)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aee7b9e into rust-lang:master Mar 27, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 27, 2021
@pickfire pickfire deleted the patch-6 branch March 29, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants