Adjust documentation links for slice::make_ascii_*case

[geeklint]

The documentation for the functions slice::to_ascii_lowercase and slice::to_ascii_uppercase contain the suggestion

To lowercase the value in-place, use make_ascii_lowercase

however the link to the suggested method takes you to the page for u8, rather than the method of that name on the same page.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[m-ou-se]

Thanks!

Can you make the links use slice:: instead of #method.? Then rustdoc will be able to verify them.

[geeklint]

Thanks!

Can you make the links use slice:: instead of #method.? Then rustdoc will be able to verify them.

Sure! I was just mirroring the inverse docs (e.g. the docs of make_ascii_lowercase). Does it make sense to also change those to slice:: ?

[m-ou-se]

Ah yes. This feature of rustdoc is relatively new, and we haven't applied it everywhere in the standard library yet. So if you see any, feel free to update them. (See also #75080, which was tracking the progress on that.)

[m-ou-se]

Oh, slice::to_ascii_uppercase does not work from the make_ascii_uppercase documentation, since the latter is defined in core and always available, and the former is only available in alloc and std. Sorry about that.

[geeklint]

Okay, so I should put the ones in core back to #method.?

[m-ou-se]

Okay, so I should put the ones in core back to #method.?

Yes, let's do that for now.

@jyn514 Do you think rustdoc should handle this? We don't have a lot of types to which we add methods in both core and alloc/std, so it might not be worth it.

[m-ou-se]

Thanks! And congrats on your first contribution to the Rust standard library ^^

@bors r+ rollup

[bors]

📌 Commit 0a30c5b has been approved by m-ou-se

[jyn514]

Oh, slice::to_ascii_uppercase does not work from the make_ascii_uppercase documentation, since the latter is defined in core and always available, and the former is only available in alloc and std. Sorry about that.

@jyn514 Do you think rustdoc should handle this? We don't have a lot of types to which we add methods in both core and alloc/std, so it might not be worth it.

This is a very large can of worms - I would like it to work, but it's hard. #74481

[bors]

⌛ Testing commit 0a30c5b with merge d4c96de...

[bors]

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing d4c96de to master...