Revert "Rollup merge of #82296 - spastorino:pubrules, r=nikomatsakis" #83713
Conversation
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit bfb5c48aba30a976b7a8e73bb67db9ac657f2bc8 has been approved by |
bors
added
S-waiting-on-bors
|
Actually, @bors r- Is there any special procedure for removing a feature gate? I don't think so, right? (cc @rust-lang/compiler) |
bors
added
S-waiting-on-author
|
Also we should probably discuss this in @rust-lang/lang meeting |
nikomatsakis
added
I-nominated
T-lang
|
Nominating for the @rust-lang/lang meeting: Given the current status of the effort around But I'd like @rylev to weigh in here too. |
The removed feature needs to be added to |
|
Personally I do feel there's some value in using It would be nice if instead removing this, just add it to the list of incomplete features... |
|
@crlf0710 yeah, the current approach to get that is a bit uglier: https://stackoverflow.com/a/67140319/10776437
|
|
We discussed this in the @rust-lang/lang meeting yesterday. There is no doubt that the feature has value, but right now there is nobody actively working to resolve the various problems that were encountered with its design, so we are inclined to remove the code (it can be added again later if the situation changes). |
There was a problem hiding this comment.
Can you add the feature to the list of deprecated features as @varkor suggested, @spastorino ?
|
@nikomatsakis I guess you meant as a removed feature, right?. I got confused also because someone else was suggesting to add it to incomplete features and to not remove it. |
|
@spastorino that is what i meant, yes. |
spastorino
force-pushed
the
revert-pub-macro-rules
branch
from
bfb5c48
to
0fd2562
Compare
| @@ -134,6 +134,8 @@ declare_features! ( | |||
| which is available from cargo build scripts with `cargo:rustc-link-arg` now")), | |||
| /// Allows using `#[main]` to replace the entrypoint `#[lang = "start"]` calls. | |||
| (removed, main, "1.53.0", Some(29634), None, None), | |||
| (removed, pub_macro_rules, "1.53.0", Some(78855), None, | |||
There was a problem hiding this comment.
I guess since is the first version in which the feature would be removed (which would be 1.53) but I wasn't 100% sure, so please check this in particular when reviewing.
spastorino
force-pushed
the
revert-pub-macro-rules
branch
from
0fd2562
to
83767d9
Compare
| @@ -134,6 +134,8 @@ declare_features! ( | |||
| which is available from cargo build scripts with `cargo:rustc-link-arg` now")), | |||
| /// Allows using `#[main]` to replace the entrypoint `#[lang = "start"]` calls. | |||
| (removed, main, "1.53.0", Some(29634), None, None), | |||
| (removed, pub_macro_rules, "1.53.0", Some(78855), None, | |||
| Some("removed due to being incomplete, in particular it does not work across crates")), | |||
There was a problem hiding this comment.
Also, always check my broken english :)
|
@nikomatsakis done, have made a couple of comments here and here |
|
Forgot to comment something I was chatting with Niko. The feature was introduced in 1.52 and the current stable version is 1.51, so we could also just apply the revert and backport the revert to beta so the feature would never reach stable. |
|
@bors r+ |
|
📌 Commit 83767d9 has been approved by |
bors
added
S-waiting-on-bors
|
Note: I would rather just revert the normal way and and let it ride the trains than bother with the increasing hassle/risk of backporting. |
|
☀️ Test successful - checks-actions |
This reverts commit e2561c5, reversing
changes made to 2982ba5.
As discussed in #83641 this feature is not complete and in particular doesn't work cross macros and given that this is not going to be included in edition 2021 nobody seems to be trying to fix the underlying problem. When can add this again I guess, whenever somebody has the time to make it work cross crates.
r? @nikomatsakis