-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store THIR in IndexVec
s instead of an Arena
#83842
Conversation
This comment has been minimized.
This comment has been minimized.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 222ac61592ccac5b91f8a3a16c3f385a1c6cb23e with merge d782db89e0c40c3406d6e9785d86798f2fb6419d... |
222ac61
to
b760ebd
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit b760ebdd0512856ff5806a3984a75ee1a0bb60fd with merge 33f4e8ad3bd066cbf2e0ef92800759e35434b3c3... |
☀️ Try build successful - checks-actions |
Queued 33f4e8ad3bd066cbf2e0ef92800759e35434b3c3 with parent 88e7862, future comparison URL. |
b760ebd
to
95bd374
Compare
Finished benchmarking try commit (33f4e8ad3bd066cbf2e0ef92800759e35434b3c3): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
This comment has been minimized.
This comment has been minimized.
95bd374
to
0d24006
Compare
This comment has been minimized.
This comment has been minimized.
0d24006
to
cf71edd
Compare
This comment has been minimized.
This comment has been minimized.
cf71edd
to
59ff5ef
Compare
This comment has been minimized.
This comment has been minimized.
59ff5ef
to
81e1d23
Compare
This comment has been minimized.
This comment has been minimized.
81e1d23
to
5d650e9
Compare
This comment has been minimized.
This comment has been minimized.
@Mark-Simulacrum The perf impact hasn't been mitigated since the perf run you mentioned, but this allows us to create a stealable query for THIR (#85273). I've added a bit of context in the PR description. |
@bors r=nikomatsakis rollup=never |
📌 Commit 7093a21 has been approved by |
⌛ Testing commit 7093a21 with merge f2a2183241cdacc66f12cc7abdbd714550066537... |
💔 Test failed - checks-actions |
Do we expect making a stealable query for THIR to alleviate the max-rss increase seen in the perf run above btw ? |
@bors retry looks like an intermittent failure, other PRs have had a networking issue on the same mac builder |
☀️ Test successful - checks-actions |
…komatsakis Add DerefOfRawPointer and CallToFunctionWith to THIR unsafeck Extends THIR unsafeck to check for two more cases of unsafe operations: dereferences of raw pointers and calls to functions with `#[target_feature]` (RFC 2396). The check for the latter is pretty much copy-pasted from the existing MIR equivalent. This will clash with rust-lang#83842 and rust-lang#85273 which are arguably more important, let's maybe focus on getting those merged first, this can wait. r? `@nikomatsakis` cc rust-lang/project-thir-unsafeck#7
…sakis Make building THIR a stealable query This PR creates a stealable `thir_body` query so that we can build the THIR only once for THIR unsafeck and MIR build. Blocked on rust-lang#83842. r? `@nikomatsakis`
This is a necessary step to store the THIR in a query: #85273. See relevant discussion on Zulip.
r? @ghost cc @cjgillot @nikomatsakis