Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render destructured struct function param names as underscore #83863

Merged
merged 3 commits into from
Apr 5, 2021
Merged

Render destructured struct function param names as underscore #83863

merged 3 commits into from
Apr 5, 2021

Conversation

eggyal
Copy link
Contributor

@eggyal eggyal commented Apr 4, 2021 •
edited
Loading

@eggyal
Copy link
Contributor Author

eggyal commented Apr 4, 2021

@rustbot label: +T-rustdoc S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 4, 2021
jyn514
jyn514 reviewed Apr 4, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the nit addressed - thanks for tackling this (and so quickly!)

src/test/rustdoc/issue-83852.rs Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Apr 4, 2021

@bors r+ squash

FYI you can avoid commits like "Merge branch 'master' of github.com:rust-lang/rust into issue-83852" by rebasing: https://rustc-dev-guide.rust-lang.org/git.html#rebasing

@bors
Copy link
Contributor

bors commented Apr 4, 2021

📌 Commit 14fac68 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2021
@eggyal
Copy link
Contributor Author

eggyal commented Apr 4, 2021

Thanks... I was just about to push a rebased and squashed commit... wasn't paying close enough attention!

@jyn514
Copy link
Member

jyn514 commented Apr 4, 2021

Haha no worries :) feel free to push the rebased commit if you want bors to show your name on the commit message.

@eggyal
Copy link
Contributor Author

eggyal commented Apr 4, 2021

I think I'll survive 😂

By the way, when you said r=me earlier, is that just a signal to other reviewers that you're happy for the PR to be marked approved by you or should I have then @bors r+d after the nit was resolved (had assumed I don't have permission for that).

@jyn514
Copy link
Member

jyn514 commented Apr 4, 2021

By the way, when you said r=me earlier, is that just a signal to other reviewers that you're happy for the PR to be marked approved by you

Yes, exactly - and it also reminds me later that I should remember to say r+ 😆

or should I have then @bors r+d after the nit was resolved (had assumed I don't have permission for that).

Correct, you don't have permissions unless you're on one of the rust-lang teams.

@jyn514
Copy link
Member

jyn514 commented Apr 4, 2021

Also it tells you that the PR is almost done and I'm only picking on small things because everything else is working :)

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 5, 2021
@Dylan-DPC
Rollup merge of rust-lang#83863 - eggyal:issue-83852, r=jyn514
c128993 
Render destructured struct function param names as underscore

Fixes rust-lang#83852

r? ``@GuillaumeGomez``
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 5, 2021
@Dylan-DPC
Rollup merge of rust-lang#83863 - eggyal:issue-83852, r=jyn514
14f858f 
Render destructured struct function param names as underscore

Fixes rust-lang#83852

r? `@GuillaumeGomez`
This was referenced Apr 5, 2021
Closed
Closed
jyn514 pushed a commit to jyn514/rust that referenced this pull request Apr 5, 2021
Rollup merge of rust-lang#83863 - eggyal:issue-83852, r=jyn514
3880665 
Render destructured struct function param names as underscore

Fixes rust-lang#83852

r? ```@GuillaumeGomez```
@jyn514 jyn514 mentioned this pull request Apr 5, 2021
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 5, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2021
@bors
Auto merge of rust-lang#83880 - Dylan-DPC:rollup-hz9ph0e, r=Dylan-DPC
39eee17 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#81922 (Let `#[allow(unstable_name_collisions)]` work for things other than function)
 - rust-lang#82483 (Use FromStr trait for number option parsing)
 - rust-lang#82739 (Use the beta compiler for building bootstrap tools when `download-rustc` is set)
 - rust-lang#83650 (Update Source Serif to release 4.004)
 - rust-lang#83826 (List trait impls before deref methods in doc's sidebar)
 - rust-lang#83831 (Add `#[inline]` to IpAddr methods)
 - rust-lang#83863 (Render destructured struct function param names as underscore)
 - rust-lang#83865 (Don't report disambiguator error if link would have been ignored)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomez
Copy link
Member

That was fast, thanks a lot! :)

@bors bors merged commit 98e7a4e into rust-lang:master Apr 5, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 5, 2021
@eggyal eggyal deleted the issue-83852 branch April 5, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

Invalid rendering for function parameters using destructuring
5 participants
@eggyal @jyn514 @bors @GuillaumeGomez @rustbot