rustdoc: Don't generate blanket impls when running --show-coverage #84030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_blanket_impls is the slowest part of rustdoc, and the coverage pass completely ignores blanket impls. This stops running it at all, and also removes some unnecessary checks in `calculate_doc_coverage` that ignored the impl anyway. We don't currently measure --show-coverage in perf.rlo, but I tested this locally on cargo and it brought the time down from 2.9 to 1.6 seconds.
Rustdoc has been able to deal with `impl trait` for almost a year now.
jyn514
added
C-cleanup
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Apr 9, 2021
|
Nice, thanks! r=me once CI pass. |
|
@bors r=GuillaumeGomez |
|
📌 Commit f67103b has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
camelid
added
the
A-doc-coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_blanket_implsis the slowest part of rustdoc, and the coverage passcompletely ignores blanket impls. This stops running it at all, and also
removes some unnecessary checks in
calculate_doc_coveragethat ignoredthe impl anyway.
We don't currently measure --show-coverage in perf.rlo, but I tested
this locally on cargo and it brought the time down from 2.9 to 1.6
seconds.
This also adds back a commented-out test; Rustdoc has been able to deal with
impl traitfor almost a year now.r? @GuillaumeGomez