-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for asm support in UI tests that require it #84099
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
Hm, I wonder if we should avoid limiting to just x86_64 - regardless, I would like to see the comment annotated with why we're requiring that target/platform. r? @Amanieu |
We could add |
All the other asm tests do this. The main reason is that, although the specific functionality that is being tested is not arch-specific, we still need to pick an architecture that supports For simplicity we only run the tests on x86_64 to ensure they are tested by CI. The arch-specific parts of |
Makes sense, OK. I think comments or using something like needs-asm-support would be good, but not necessarily blockers. |
6fd4c7d
to
5e87f97
Compare
@bors r+ |
📌 Commit 5e87f97 has been approved by |
Check for asm support in UI tests that require it Add `needs-asm-support` compiletest directive, and use it in asm tests that require asm support without relying on any architecture specific features. Closes rust-lang#84038.
5e87f97
to
da40e69
Compare
Add `needs-asm-support` compiletest directive, and use it in asm tests that require asm support without relying on any architecture specific features.
@bors r+ |
📌 Commit da40e69 has been approved by |
☀️ Test successful - checks-actions |
Add
needs-asm-support
compiletest directive, and use it in asm teststhat require asm support without relying on any architecture specific
features.
Closes #84038.