Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address comments for vecdeque_binary_search #78021 #84145

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Address comments for vecdeque_binary_search #78021 #84145

merged 3 commits into from
Apr 16, 2021

Conversation

vojtechkral
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2021
@vojtechkral vojtechkral mentioned this pull request Apr 12, 2021
Closed
5 tasks
m-ou-se
m-ou-se reviewed Apr 14, 2021
View reviewed changes
Copy link
Member

@m-ou-se m-ou-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good! Only two comments about the documentation:

library/alloc/src/collections/vec_deque/mod.rs Outdated Show resolved Hide resolved
@m-ou-se m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2021
@vojtechkral vojtechkral force-pushed the vecdeque-binary-search branch from efb36c0 to 44be1c2 Compare April 15, 2021 21:24
@vojtechkral
Copy link
Contributor Author

@m-ou-se updated, fixed the doc comments hopefully...

@m-ou-se
Copy link
Member

m-ou-se commented Apr 16, 2021

Thanks for working on this!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 16, 2021

📌 Commit 44be1c2 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2021
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2021
@bors
Auto merge of rust-lang#84241 - Dylan-DPC:rollup-jk9nt6k, r=Dylan-DPC
2faef12 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#83337 (rustdoc: Hide item contents, not items)
 - rust-lang#83944 (Fix a couple resolve bugs from binder refactor)
 - rust-lang#84145 (Address comments for vecdeque_binary_search rust-lang#78021)
 - rust-lang#84172 (Compiler error messages: reduce assertiveness of message E0384)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a5ec5cf into rust-lang:master Apr 16, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vojtechkral @rust-highfive @m-ou-se @bors @rustbot