Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid an Option<Option<_>> #84164

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Avoid an Option<Option<_>> #84164

merged 1 commit into from
Apr 13, 2021

Conversation

LingMan
Copy link
Contributor

@LingMan LingMan commented Apr 13, 2021

By simply swapping the calls to map and and_then around the complexity of
handling an Option<Option<_>> disappears.

@rustbot modify labels +C-cleanup +T-compiler

@LingMan
Avoid an Option<Option<_>>
28aed81 
By simply swapping the calls to `map` and `and_then` around the complexity of
handling an `Option<Option<_>>` disappears.
@rustbot rustbot added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 13, 2021
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2021
@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 13, 2021

📌 Commit 28aed81 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2021
@bors
Copy link
Contributor

bors commented Apr 13, 2021

⌛ Testing commit 28aed81 with merge 132b4e5...

@bors
Copy link
Contributor

bors commented Apr 13, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 132b4e5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 13, 2021
@bors bors merged commit 132b4e5 into rust-lang:master Apr 13, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 13, 2021
@LingMan LingMan deleted the option_option branch April 13, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
5 participants
@LingMan @rust-highfive @estebank @bors @rustbot