Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid pub/priv where it has no effect #8423

Closed
wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

Closes #5495

}
}
}
ast::item_impl(*) => {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you didn't lump this in with the above => {} patterns?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case above needs to be matched first and putting this up above would otherwise prevent it from being matched.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't the cases above be moved to be below?

@emberian
Copy link
Member

@alexcrichton needs a rebase already

bors added a commit that referenced this pull request Aug 13, 2013
@bors bors closed this Aug 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Forbid pub and priv in positions where they do not change the default behavior
5 participants