Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Remove unnecessary provided_trait_methods field from Impl #84463

Merged
merged 1 commit into from
May 1, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 23, 2021

It can be calculated on-demand.

Helps with #76382.

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. labels Apr 23, 2021
@rust-highfive
Copy link
Collaborator

r? @CraftSpider

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2021
@jyn514
Copy link
Member Author

jyn514 commented Apr 23, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 23, 2021
@bors
Copy link
Contributor

bors commented Apr 23, 2021

⌛ Trying commit bb1a5dd05219bfb178be98baf976464c9ebd2f8a with merge 1e800a725cbcb3b7f29c5cb704e0f85f3db7aabd...

@bors
Copy link
Contributor

bors commented Apr 23, 2021

☀️ Try build successful - checks-actions
Build commit: 1e800a725cbcb3b7f29c5cb704e0f85f3db7aabd (1e800a725cbcb3b7f29c5cb704e0f85f3db7aabd)

@rust-timer
Copy link
Collaborator

Queued 1e800a725cbcb3b7f29c5cb704e0f85f3db7aabd with parent 7f4afdf, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (1e800a725cbcb3b7f29c5cb704e0f85f3db7aabd): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 23, 2021
@jyn514
Copy link
Member Author

jyn514 commented Apr 23, 2021

Around -.3% in instruction counts across the board, except regex which regressed by .3%. Up to -1.8% max rss with no major regressions. I think that tradeoff is worth it.

@CraftSpider
Copy link
Contributor

CraftSpider commented Apr 27, 2021

Code looks good to me, I agree with the trade-off analysis. Needs a rebase to fix conflicts, then it should be good. I also appreciate the minor code deduplication :P

@CraftSpider
Copy link
Contributor

@rustbot label: -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2021
@jyn514
Copy link
Member Author

jyn514 commented May 1, 2021

@bors r=CraftSpider

@bors
Copy link
Contributor

bors commented May 1, 2021

📌 Commit b1f5917 has been approved by CraftSpider

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2021
@bors
Copy link
Contributor

bors commented May 1, 2021

⌛ Testing commit b1f5917 with merge 3d67e07...

@bors
Copy link
Contributor

bors commented May 1, 2021

☀️ Test successful - checks-actions
Approved by: CraftSpider
Pushing 3d67e07 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 1, 2021
@bors bors merged commit 3d67e07 into rust-lang:master May 1, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 1, 2021
@jyn514 jyn514 deleted the refactor-impl branch May 1, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants