-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Remove unnecessary provided_trait_methods
field from Impl
#84463
Conversation
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit bb1a5dd05219bfb178be98baf976464c9ebd2f8a with merge 1e800a725cbcb3b7f29c5cb704e0f85f3db7aabd... |
☀️ Try build successful - checks-actions |
Queued 1e800a725cbcb3b7f29c5cb704e0f85f3db7aabd with parent 7f4afdf, future comparison URL. |
Finished benchmarking try commit (1e800a725cbcb3b7f29c5cb704e0f85f3db7aabd): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Around -.3% in instruction counts across the board, except regex which regressed by .3%. Up to -1.8% max rss with no major regressions. I think that tradeoff is worth it. |
Code looks good to me, I agree with the trade-off analysis. Needs a rebase to fix conflicts, then it should be good. I also appreciate the minor code deduplication :P |
@rustbot label: -S-waiting-on-review +S-waiting-on-author |
It can be calculated on-demand.
@bors r=CraftSpider |
📌 Commit b1f5917 has been approved by |
☀️ Test successful - checks-actions |
It can be calculated on-demand.
Helps with #76382.