Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Remove unnecessary dummy span #84492

Merged
merged 1 commit into from
Apr 24, 2021
Merged

rustdoc: Remove unnecessary dummy span #84492

merged 1 commit into from
Apr 24, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 23, 2021

Follow-up to #84460 (comment).

r? @camelid

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 23, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2021
camelid
camelid reviewed Apr 23, 2021
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but you can skip it if you like. r=me with CI passing

src/librustdoc/visit_ast.rs Show resolved Hide resolved
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2021
@jyn514
Copy link
Member Author

jyn514 commented Apr 23, 2021

@bors r=camelid

@bors
Copy link
Contributor

bors commented Apr 23, 2021

📌 Commit 7c50b82 has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 23, 2021
@jyn514
Copy link
Member Author

jyn514 commented Apr 23, 2021

@bors rollup

@JohnTitor JohnTitor mentioned this pull request Apr 24, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2021
@bors
Auto merge of rust-lang#84501 - JohnTitor:rollup-wxu1thu, r=JohnTitor
e11a9fa 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#83990 (implement `TrustedRandomAccess` for `Take` iterator adapter)
 - rust-lang#84250 (bootstrap: use bash on illumos to run install scripts)
 - rust-lang#84320 (Use details tag for trait implementors.)
 - rust-lang#84436 (Make a few functions private)
 - rust-lang#84453 (Document From implementations for Waker and RawWaker)
 - rust-lang#84458 (Remove unnecessary fields and parameters in rustdoc)
 - rust-lang#84485 (Add some associated type bounds tests)
 - rust-lang#84489 (Mention FusedIterator case in Iterator::fuse doc)
 - rust-lang#84492 (rustdoc: Remove unnecessary dummy span)
 - rust-lang#84496 (Add some specialization tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aae871d into rust-lang:master Apr 24, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 24, 2021
@jyn514 jyn514 deleted the span branch April 24, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

Assignees

@camelid camelid

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jyn514 @bors @camelid @rust-highfive @rustbot