Add link to Issue #34202 in udp docs #84835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
m-ou-se
reviewed
May 2, 2021
library/std/src/net/udp.rs
Outdated
| @@ -159,7 +159,7 @@ impl UdpSocket { | |||
| /// This will return an error when the IP version of the local socket | |||
| /// does not match that returned from [`ToSocketAddrs`]. | |||
| /// | |||
| /// See issue #34202 for more details. | |||
| /// See [`Issue #34202`] for more details. | |||
There was a problem hiding this comment.
The backticks are only needed for code, to format it monospace font.
Suggested change
| /// See [`Issue #34202`] for more details. | |
| /// See [issue #34202] for more details. |
library/std/src/net/udp.rs
Outdated
| @@ -169,6 +169,8 @@ impl UdpSocket { | |||
| /// let socket = UdpSocket::bind("127.0.0.1:34254").expect("couldn't bind to address"); | |||
| /// socket.send_to(&[0; 10], "127.0.0.1:4242").expect("couldn't send data"); | |||
| /// ``` | |||
| /// | |||
| /// [`Issue #34202`]: https://github.com/rust-lang/rust/issues/34202 | |||
There was a problem hiding this comment.
Suggested change
| /// [`Issue #34202`]: https://github.com/rust-lang/rust/issues/34202 | |
| /// [issue #34202]: https://github.com/rust-lang/rust/issues/34202 |
Signed-off-by: wcampbell <wcampbell1995@gmail.com>
wcampbell0x2a
force-pushed
the
add-issue-34202-link
branch
from
4958b61 to
e4250a0
Compare
|
Thanks! @bors r+ rollup |
|
📌 Commit e4250a0 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 3, 2021
… r=m-ou-se Add link to Issue rust-lang#34202 in udp docs
This was referenced May 3, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2021
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#84835 (Add link to Issue rust-lang#34202 in udp docs) - rust-lang#84852 (Change librustdoc write!(.. \n) to writeln!(..); fix comment grammar) - rust-lang#84854 (use double quotes and full path for E0761) - rust-lang#84856 (Correct stability of ErrorKind::OutOfMemory) - rust-lang#84858 (Fix stability attributes of byte-to-string specialization) - rust-lang#84860 (Link to MCP from target tier policy) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.