-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Bump cargo_metadata
to 0.13
#84850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cargo_metadata
to 0.13
#84850
Conversation
This brings the number of copies of `cargo_metadata` from 3 to 2. Removing the final duplicate will require updates to `rls` and `rustfmt`
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
(rust-highfive has picked a reviewer for you, use r? to override) |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Maybe use 0.12.* for now? There was some discussion about additional dependencies oli-obk/cargo_metadata#152 |
@Aaron1011 I see you marked this as waiting-on-author, is this PR a draft? |
☔ The latest upstream changes (presumably #85954) made this pull request unmergeable. Please resolve the merge conflicts. |
@Aaron1011 CI still red, and there's a merge conflict. |
I don't think its good to bump it to 0.13 now, as i already updated it to 0.12 over rls\rustfmt to reduce duplication (waiting when it will be merged into rust repo). Only need update it for If it will be updated to 0.13, this will add duplicates again. |
ping from triage: |
I'll close this PR for now, since it's unclear if it's still relevant. |
This brings the number of copies of
cargo_metadata
from 3 to 2.Removing the final duplicate will require updates to
rls
andrustfmt