fix null pointer error messages #85034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 4dddc38 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 7, 2021
fix null pointer error messages I got the `match` in rust-lang#84972 wrong, this fixes that. Also avoid redundant "inbounds test failed:" prefix. Should fix rust-lang#85027 r? `@oli-obk`
This comment has been minimized.
This comment has been minimized.
|
@bors r- |
bors
added
S-waiting-on-author
|
@RalfJung if you are r-'g a pr that's in a rollup, ensure that the rollup is r-'d as well :) thanks |
|
@Dylan-DPC sorry, I got the red CI email while being in a meeting so I didn't have time to read over the log in this issue so I missed the fact that this was rolled up... @bors r=oli-obk |
|
📌 Commit 6386656 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 8, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#76808 (Improve diagnostics for functions in `struct` definitions) - rust-lang#84887 (Remove SpanInterner::get) - rust-lang#85034 (fix null pointer error messages) - rust-lang#85038 (Don't stop running rustdoc-gui tests at first failure) - rust-lang#85044 (Use `path.exists()` instead of `fs::metadata(path).is_ok()`) - rust-lang#85052 (rustdoc: Link to the docs on namespaces when an unknown disambiguator is found) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the
matchin #84972 wrong, this fixes that.Also avoid redundant "inbounds test failed:" prefix.
Should fix #85027
r? @oli-obk