Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RLS #85058

Merged
merged 1 commit into from
May 8, 2021
Merged

Update RLS #85058

merged 1 commit into from
May 8, 2021

Conversation

Xanewok
Copy link
Member

@Xanewok Xanewok commented May 7, 2021

This mostly just includes rust-lang/rls@e33f4e6 so that this fixes #85055 (clippy-related breakage).

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2021
@Xanewok
Copy link
Member Author

Xanewok commented May 8, 2021

@bors r+ p=1 (fixes toolstate)

@bors
Copy link
Collaborator

bors commented May 8, 2021

📌 Commit 3a17b01 has been approved by Xanewok

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2021
@Xanewok Xanewok assigned Xanewok and unassigned Mark-Simulacrum May 8, 2021
@bors
Copy link
Collaborator

bors commented May 8, 2021

⌛ Testing commit 3a17b01 with merge e002ac7...

@bors
Copy link
Collaborator

bors commented May 8, 2021

☀️ Test successful - checks-actions
Approved by: Xanewok
Pushing e002ac7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 8, 2021
@bors bors merged commit e002ac7 into rust-lang:master May 8, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 8, 2021
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #85058!

Tested on commit e002ac7.
Direct link to PR: #85058

🎉 rls on windows: build-fail → test-pass (cc @Xanewok).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 8, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#85058!
0289b51 
Tested on commit rust-lang/rust@e002ac7.
Direct link to PR: <rust-lang/rust#85058>

🎉 rls on windows: build-fail → test-pass (cc @Xanewok).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok).
@bors bors mentioned this pull request May 8, 2021
Merged
@Xanewok Xanewok deleted the update-rls branch May 8, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Xanewok Xanewok

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#84980
5 participants
@Xanewok @rust-highfive @bors @Mark-Simulacrum @rustbot