-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "panic message is not a string literal" warning #85075
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test to the src/test/ui/lint
directory so we have the expected output for this?
This warning always referenced panic! even in case of an assert. Related to rust-lang#84656
Thanks! @bors r+ rollup |
📌 Commit 8f14592 has been approved by |
Improve "panic message is not a string literal" warning This warning always referenced panic! even in case of an assert. Related to rust-lang#84656
⌛ Testing commit 8f14592 with merge bdf3eee5ffc8c014ef306d77fa6efc758f7ff962... |
💔 Test failed - checks-actions |
@bors retry |
Rollup of 6 pull requests Successful merges: - rust-lang#85050 (Fix suggestions for missing return type lifetime specifiers) - rust-lang#85075 (Improve "panic message is not a string literal" warning) - rust-lang#85096 (Make unchecked_{add,sub,mul} inherent methods unstably const) - rust-lang#85112 (ensure failing promoteds in const/static bodies are handled correctly) - rust-lang#85146 (Provide io::Seek::rewind) - rust-lang#85147 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This warning always referenced panic! even in case of an
assert. Related to #84656