-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return EvaluatedToOk
when type in outlives predicate is global
#85090
Conversation
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 3341e59a51aae0f4e7563201909c9c40e741503b with merge 4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93... |
☀️ Try build successful - checks-actions |
Queued 4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93 with parent ff34b91, future comparison URL. |
Finished benchmarking try commit (4b5ec6fb38614d722c06f0f0de0d68e5dbaeea93): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 3341e59a51aae0f4e7563201909c9c40e741503b with merge 91eef17632935ce04682e8e7bdc0ce65a52370d9... |
☀️ Try build successful - checks-actions |
Queued 91eef17632935ce04682e8e7bdc0ce65a52370d9 with parent 17f30e5, future comparison URL. |
Finished benchmarking try commit (91eef17632935ce04682e8e7bdc0ce65a52370d9): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Overall improvements up to 1.0% with 3 regressions of up to 0.5%. |
I am not able to review any PRs in the near future. |
@bors r+ |
📌 Commit 3341e59a51aae0f4e7563201909c9c40e741503b has been approved by |
A global type doesn't reference any local regions or types, so it's guaranteed to outlive any region.
3341e59
to
1f7cb16
Compare
@nikomatsakis: I added a region to |
@bors r=matthewjasper,jackh726 |
📌 Commit 1f7cb16 has been approved by |
⌛ Testing commit 1f7cb16 with merge cf65b707d871d443059f2b9881cfbd6cf31d850b... |
💔 Test failed - checks-actions |
@bors retry |
This PR doesn't fix the root cause of the |
☀️ Test successful - checks-actions |
A global type doesn't reference any local regions or types, so it's
guaranteed to outlive any region.