Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented May 11, 2021

In #85148, I made an invalid change on the border radius of the doc code blocks (look in the top left and bottom left corners of the code blocks).

Before this fix:

Screenshot from 2021-05-11 11-14-59

After this fix:

Screenshot from 2021-05-11 11-05-29

r? @jsha

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels May 11, 2021
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2021
@jsha
Copy link
Contributor

jsha commented May 12, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented May 12, 2021

📌 Commit e55283a has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2021
@GuillaumeGomez
Copy link
Member Author

@bors: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2021
…laumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#84793 (Recover from invalid `struct` item syntax)
 - rust-lang#85117 (Move global click handlers to per-element ones.)
 - rust-lang#85141 (Update documentation for SharedContext::maybe_collapsed_doc_value)
 - rust-lang#85174 (Fix border radius for doc code blocks in rustdoc)
 - rust-lang#85205 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bc26def into rust-lang:master May 12, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 12, 2021
@GuillaumeGomez GuillaumeGomez deleted the doc-code-block-border-radius branch May 12, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants