Skip to content

syntax: add a local_data_key macro that creates a key for access to the TLS. #8534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libstd/local_data.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ wish to store.
~~~{.rust}
use std::local_data;

static key_int: local_data::Key<int> = &local_data::Key;
static key_vector: local_data::Key<~[int]> = &local_data::Key;
local_data_key!(key_int: int);
local_data_key!(key_vector: ~[int]);

local_data::set(key_int, 3);
local_data::get(key_int, |opt| assert_eq!(opt, Some(&3)));
Expand Down
11 changes: 11 additions & 0 deletions src/libsyntax/ext/expand.rs
Original file line number Diff line number Diff line change
Expand Up @@ -957,6 +957,17 @@ pub fn std_macros() -> @str {
println(fmt!($($arg),+))
)
)

// NOTE: use this after a snapshot lands to abstract the details
// of the TLS interface.
macro_rules! local_data_key (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get the syntax local_data_key!(name: type) ? I think conditions manage to do this

($name:ident: $ty:ty) => (
static $name: ::std::local_data::Key<$ty> = &::std::local_data::Key;
);
(pub $name:ident: $ty:ty) => (
pub static $name: ::std::local_data::Key<$ty> = &::std::local_data::Key;
)
)
}";
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/core-tls-store-pointer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

use std::local_data;

static key: local_data::Key<@&int> = &local_data::Key;
local_data_key!(key: @&int)
//~^ ERROR only 'static is allowed

fn main() {}
22 changes: 22 additions & 0 deletions src/test/compile-fail/macro-local-data-key-priv.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

use std::local_data;

// check that the local data keys are private by default.

mod bar {
local_data_key!(baz: float)
}

fn main() {
local_data::set(bar::baz, -10.0);
//~^ ERROR unresolved name `bar::baz`
}
28 changes: 28 additions & 0 deletions src/test/run-pass/macro-local-data-key.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

use std::local_data;

local_data_key!(foo: int)

mod bar {
local_data_key!(pub baz: float)
}

fn main() {
local_data::get(foo, |x| assert!(x.is_none()));
local_data::get(bar::baz, |y| assert!(y.is_none()));

local_data::set(foo, 3);
local_data::set(bar::baz, -10.0);

local_data::get(foo, |x| assert_eq!(*x.unwrap(), 3));
local_data::get(bar::baz, |y| assert_eq!(*y.unwrap(), -10.0));
}