Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow async {} expressions in const contexts #85353

Merged
merged 2 commits into from
May 17, 2021
Merged

Allow async {} expressions in const contexts #85353

merged 2 commits into from
May 17, 2021

Conversation

jonas-schievink
Copy link
Contributor

Gated behind a new const_async_blocks feature.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2021
@jonas-schievink
Copy link
Contributor Author

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned estebank May 16, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jonas-schievink jonas-schievink mentioned this pull request May 16, 2021
Open
3 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented May 16, 2021

@bors r+

@bors
Copy link
Contributor

bors commented May 16, 2021

📌 Commit 014e8d4 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2021
@bors
Copy link
Contributor

bors commented May 17, 2021

⌛ Testing commit 014e8d4 with merge 44ec846...

@bors
Copy link
Contributor

bors commented May 17, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 44ec846 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2021
@bors bors merged commit 44ec846 into rust-lang:master May 17, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 17, 2021
@bors bors mentioned this pull request May 17, 2021
Merged
@jonas-schievink jonas-schievink deleted the async-blocks-in-ctfe branch May 17, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jonas-schievink @rust-highfive @rust-log-analyzer @oli-obk @bors @estebank @rustbot