-
Notifications
You must be signed in to change notification settings - Fork 13.3k
visitor trait rewrite step2 #8539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visitor trait rewrite step2 #8539
Conversation
Yuck, I just duplicated a bunch of this work. :( We should coordinate. This is my fault, sorry. |
@pcwalton maybe I should have cc'ed you on this PR as well, I guess. If you look at #8527, you will see links to ports of all but one of the visitor passes. I was just trying to break up the pull requests to increase the chance that they would not conflict with other peoples' on-going work. So it might be a better use of your time to pull those over to your repo and then file pull requests for them. That, or just wait until I return on Monday and I'll file them myself. |
(for third parties reivewing this: pcwalton's comment was referring to PR #8567 which actually still hasn't landed, so it might be a better idea to focus on landing this variant since it has nearly the whole path to completion laid out in front of it.) |
I'm going to keep r+'ing both your work until one of you lands or tires of duplicating one another's work :) It's excellent work anyways! Glad to see. |
@graydon sweeeet. |
…r=graydon,nikomatsakis r? @nikomatsakis Follow up to #8527 (which was step 1 of 5). See that for overall description Part of #7081
…giraffate Move iter_with_drain to nursery cc rust-lang#8538 rust-lang#8539 r? `@giraffate` changelog: Move [`iter_with_drain`] to nursery
r? @nikomatsakis
Follow up to #8527 (which was step 1 of 5). See that for overall description
Part of #7081