Optimize proc macro bridge #85390
Merged
Optimize proc macro bridge #85390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 4df5d58e6e7ca658565a0ffc9853cd791788ea29 with merge 55c4f6ccc851db7f04cd03a160665208bcaa65ea... |
|
☀️ Try build successful - checks-actions |
|
Queued 55c4f6ccc851db7f04cd03a160665208bcaa65ea with parent fe72845, future comparison URL. |
|
Finished benchmarking try commit (55c4f6ccc851db7f04cd03a160665208bcaa65ea): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
I don’t think adjustment on ra side is required, but we’ll want to port this over some day to keep the code identical. I wonder if we should look into sharing the impl here via a published crate, and not via copy-paste. cc @edwin0cheng |
petrochenkov
added
S-waiting-on-author
copy_from_slice generally falls back to memcpy/memmove, which is much more expensive than we need to write a single element in. This saves 0.26% instructions on the diesel benchmark.
This is a 0.15% win on diesel.
This allows a more efficient implementation (avoiding a fallback to memmove, which is not optimal for short writes). This saves 0.29% on diesel.
Mark-Simulacrum
force-pushed
the
fast-bridge
branch
from
4df5d58
to
8c20808
Compare
Mark-Simulacrum
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 8c20808 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 8c20808 with merge 73f497f7caef0a3168037b452f46917b93c85590... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry thread 'main' panicked at 'client.read_exact(&mut header) failed with Connection reset by peer (os error 104)', src/tools/remote-test-client/src/main.rs:310:9 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
Jun 4, 2021
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
Jun 12, 2021
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
Jun 20, 2021
eddyb
reviewed
Jul 1, 2021
| extend_from_slice: extern "C" fn(Buffer<T>, Slice<'_, T>) -> Buffer<T>, | ||
| reserve: extern "C" fn(Buffer<T>, usize) -> Buffer<T>, |
There was a problem hiding this comment.
This is the last use of Slice and now Slice can be removed (not sure why it didn't warn/error as unused).
lf-
added a commit
to lf-/rust
that referenced
this pull request
Jul 1, 2021
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 1, 2021
proc_macro/bridge: Remove dead code Slice type See rust-lang#85390 (comment)
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 1, 2021
proc_macro/bridge: Remove dead code Slice type See rust-lang#85390 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the proc macro bridge code for a win of 0.7% instruction counts on the diesel-check benchmark (non-incr, full). These wins are small, but hopefully not limited to just the diesel benchmark; the code is also not seriously impacted by the changes here.