Build crtbegin.o/crtend.o from source code #85395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
12101111
changed the title
|
Test with the code from #47551 : #![feature(backtrace)]
#[derive(Clone, Copy)]
struct Foo {
array: [u64; 10240],
}
impl Foo {
const fn new() -> Self {
Self {
array: [0x1122_3344_5566_7788; 10240]
}
}
}
static BAR: [Foo; 10240] = [Foo::new(); 10240];
fn main() {
let bt = std::backtrace::Backtrace::force_capture();
println!("Hello, world! {:?}", bt);
println!("{:x}", BAR[0].array[0]);
}The broken rustc that don't link to crtbeginS.o/crtendS.o: rustc in this PR: |
|
r? @nagisa or @petrochenkov perhaps? I don't know too much about our crtbegin self-contained objects story, and whether building them ourselves (vs. using the ones in system roots) makes sense. |
|
gcc's crtbegin.o/crtend.o is built when gcc bootstrap. Those target use And the current copy mechanism don't work well when using clang as C compiler. |
A working clang toolchain will still link these objects from somewhere, so they can be copied from the same place. |
They are the same file. rust/src/ci/docker/host-x86_64/dist-various-1/Dockerfile Lines 63 to 78 in 1969c2e
Clang don't provided a command line to get the location of compiler-rt. And compiler-rt is optional for clang. |
It does: |
|
This is intrinsics, not crtbegin.o/crtend.o. The logic in clang is at A full clang installation should have |
The files must always exist somewhere, otherwise the C toolchain will be non-functional. My main question is what is simpler, less error-prone and requires less support - implementing the object search for all platforms on which |
petrochenkov
added
S-waiting-on-author
|
@12101111 |
petrochenkov
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 5b44522ff115b8a2ac82217c6a69233988aae84e has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 5b44522ff115b8a2ac82217c6a69233988aae84e with merge 5168f9db7cf61a646190550e7fd0c1165898ca49... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 61c1155 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
rustbot
added
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2021
…ulacrum [beta] backports * Disable the machine outliner by default rust-lang#86020 * Fix incorrect gating of nonterminals in key-value attributes rust-lang#85445 * Build crtbegin.o/crtend.o from source code rust-lang#85395 * Bring back x86_64-sun-solaris target to rustup rust-lang#85252 * Preserve SyntaxContext for invalid/dummy spans in crate metadata rust-lang#85211 * [beta] backport: Remove unsound TrustedRandomAccess implementations rust-lang#86222 r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build crtbengin.o/crtend.o from source code instead of copying from gcc.
The crtbegin and crtend implementation from llvm don't need
crtbeginS.ofor PIC.crtbegin{,S,T}.ois unified into one genericcrtbegin.o. See the comments in https://reviews.llvm.org/D28791#1419436 and https://reviews.llvm.org/D28791#1420914fix: #85310 , fix: #47551 , fix: #84033