Improve display for "copy-path" button, making it more discreet #85407
Conversation
GuillaumeGomez
added
T-rustdoc
|
Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
|
It could be nice to have a highlight on hover too, since there's no longer the border changing color. |
|
I was thinking about it and thought that the cursor change would be enough. What do you suggest? Making the color a bit lighter? |
|
Lighter on the dark themes, darker on the light theme (which would require making the base color on ayu a bit darker so it has somewhere to lighten towards). |
GuillaumeGomez
force-pushed
the
copy-path-display-improvement
branch
from
8029814
to
2009393
Compare
|
I updated the screenshots. The difference is very easy to spot when using it but with just the screenshots, not that much... (mostly on light and dark themes) |
jsha
changed the title
|
This looks good, but why the complex CSS filter? Why not just set a different color? |
|
Because of the svg, we can't change its color easily, we have to use tricks. But since it's only grey, we can simply use |
GuillaumeGomez
force-pushed
the
copy-path-display-improvement
branch
from
2009393
to
5d004c1
Compare
|
Simplified the rules for the same result (and also re-updated the screenshots). |
|
@bors r+ |
|
📌 Commit 5d004c1 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 7 pull requests Successful merges: - rust-lang#84462 (rustdoc: use focus for search navigation) - rust-lang#85251 (Make `const_generics_defaults` not an incomplete feature) - rust-lang#85404 (Backport 1.52.1 release notes) - rust-lang#85407 (Improve display for "copy-path" button, making it more discreet) - rust-lang#85423 (Don't require cmake on Windows when LLVM isn't being built) - rust-lang#85428 (Add x.py pre-setup instructions) - rust-lang#85442 (fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
As suggested by @Nemo157 here:
r? @jsha