[MCP] introduce ty::WhereClause to align chalk and rustc dyn repr #85466

csmoe · 2021-05-19T11:58:06Z

Closes rust-lang/types-team#30
Closes rust-lang/compiler-team#433
r? @nikomatsakis

rust-highfive · 2021-05-19T11:58:09Z

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

bors · 2021-06-04T05:12:32Z

☔ The latest upstream changes (presumably #85954) made this pull request unmergeable. Please resolve the merge conflicts.

csmoe · 2021-06-08T03:13:55Z

@nikomatsakis ping for a review🔔

jackh726 · 2021-07-03T16:56:44Z

compiler/rustc_middle/src/ty/sty.rs

@@ -716,11 +716,13 @@ pub enum ExistentialPredicate<'tcx> {
    AutoTrait(DefId),
 }

-impl<'tcx> ExistentialPredicate<'tcx> {
+pub type ExistentialPredicate<'tcx> = Binder<'tcx, WhereClause<'tcx>>;


This isn't quite right. The difference between rustc and Chalk isn't solely the name. In Chalk, there's actually two layers of Binders. One that contains a single type that represents Self, and one that represents the vars on the predicates itself. See https://github.com/rust-lang/chalk/blob/802599ce2ca02f322c078f472e64c5cd3a208225/chalk-solve/src/rust_ir.rs#L233

edit: this isn't actually accurate; let me write up a better comment

I guess the big thing missing here is the removal of erase_self_ty. And along with that, make the Self ty actually be a bound var.

bors · 2021-07-26T05:59:56Z

☔ The latest upstream changes (presumably #87424) made this pull request unmergeable. Please resolve the merge conflicts.

JohnCSimon · 2021-09-13T03:43:51Z

ping from triage:
@csmoe
Returning to you to address merge conflicts and after that switch this back to S-waiting-on-review.
thanks.

nikomatsakis · 2021-09-15T16:56:38Z

@csmoe sorry this PR disappeared from my radar

nikomatsakis · 2021-09-15T16:57:02Z

Are you still around?

csmoe · 2021-09-24T00:27:05Z

Are you still around?

yep, time was tough. I'm back on this:)

nikomatsakis · 2021-09-30T20:16:34Z

Augh! Let me give this a quick review @csmoe

nikomatsakis

OK, so, I read the PR. From what I can tell, before this PR:

We have Binder<ExistentialPredicate>, where ExistentialPredicate is a subset of predicates that don't have Self position specified.

After this PR:

We introduce WhereClause to be the old ExistentialPredicate, and we make ExistentialPredicate an alias for Binder<WC>

This seems good, but indeed only a first step in the ultimate direction. Ultimately we want to extend WhereClause so it includes the Self type, and @jackh726 is right that this will mean introducing another level of Binder.

I think we also want to share WhereClause with Predicate.

bors · 2021-10-08T12:10:09Z

☔ The latest upstream changes (presumably #89619) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2021-11-09T23:23:38Z

☔ The latest upstream changes (presumably #90734) made this pull request unmergeable. Please resolve the merge conflicts.

rust-log-analyzer · 2021-11-14T13:04:52Z

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.58.0-nightly (6f7dc9a98 2021-11-14) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z symbol-mangling-version=legacy -Z macro-backtrace -Z crate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/") -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=0 -C debug-assertions=on -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C llvm-args=-import-instr-limit=10 -C embed-bitcode=yes --crate-type lib
note: some of the compiler flags provided by cargo are hidden

query stack during panic:
query stack during panic:
#0 [inferred_outlives_crate] computing the inferred outlives predicates for items in this crate
#1 [inferred_outlives_of] computing inferred outlives predicates of `cell::UnsafeCell`
error: could not compile `core`
Build completed unsuccessfully in 0:04:06

bors · 2021-11-28T16:17:02Z

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

crlf0710 · 2021-12-17T17:53:17Z

@csmoe Ping from triage: Any updates here?

Dylan-DPC · 2022-02-22T02:15:00Z

Closing this as inactive

rust-highfive assigned nikomatsakis May 19, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2021

csmoe force-pushed the dyn-repr branch from dfd1657 to 13b5427 Compare May 19, 2021 12:00

This comment has been minimized.

Sign in to view

csmoe mentioned this pull request May 19, 2021

Introduce ty::WhereClause to align chalk and rustc dyn representation rust-lang/compiler-team#433

Closed

3 tasks

csmoe force-pushed the dyn-repr branch from 13b5427 to 01fafbf Compare May 21, 2021 07:40

csmoe force-pushed the dyn-repr branch from 01fafbf to dec0221 Compare June 8, 2021 02:18

csmoe force-pushed the dyn-repr branch from dec0221 to 72ab6ca Compare June 18, 2021 00:56

jackh726 requested changes Jul 3, 2021

View reviewed changes

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021

inquisitivecrystal added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2021

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021

nikomatsakis reviewed Sep 30, 2021

View reviewed changes

csmoe force-pushed the dyn-repr branch from 72ab6ca to 227e2c0 Compare October 7, 2021 08:32

This comment has been minimized.

Sign in to view

JohnCSimon removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 24, 2021

JohnCSimon added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 24, 2021

csmoe force-pushed the dyn-repr branch from 8c71935 to 12453ce Compare October 31, 2021 10:39

This comment has been minimized.

Sign in to view

csmoe force-pushed the dyn-repr branch from 12453ce to 5df4764 Compare November 1, 2021 14:58

This comment has been minimized.

Sign in to view

csmoe added 2 commits November 14, 2021 17:19

introduce ty::WhereClause to align chalk and rustc dyn repr

6bb470e

add Self type into whereclause

c6a4dbe

csmoe force-pushed the dyn-repr branch from 5df4764 to c6a4dbe Compare November 14, 2021 12:16

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2022

Dylan-DPC closed this Feb 22, 2022

Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MCP] introduce ty::WhereClause to align chalk and rustc dyn repr #85466

[MCP] introduce ty::WhereClause to align chalk and rustc dyn repr #85466

csmoe commented May 19, 2021 •

edited

Loading

rust-highfive commented May 19, 2021

This comment has been minimized.

bors commented Jun 4, 2021

csmoe commented Jun 8, 2021

jackh726 Jul 3, 2021 •

edited

Loading

jackh726 Jul 3, 2021

bors commented Jul 26, 2021

JohnCSimon commented Sep 13, 2021

nikomatsakis commented Sep 15, 2021

nikomatsakis commented Sep 15, 2021

csmoe commented Sep 24, 2021 •

edited

Loading

nikomatsakis commented Sep 30, 2021

nikomatsakis left a comment

This comment has been minimized.

bors commented Oct 8, 2021

This comment has been minimized.

This comment has been minimized.

bors commented Nov 9, 2021

rust-log-analyzer commented Nov 14, 2021

bors commented Nov 28, 2021

crlf0710 commented Dec 17, 2021

Dylan-DPC commented Feb 22, 2022

[MCP] introduce ty::WhereClause to align chalk and rustc dyn repr #85466

[MCP] introduce ty::WhereClause to align chalk and rustc dyn repr #85466

Conversation

csmoe commented May 19, 2021 • edited Loading

rust-highfive commented May 19, 2021

This comment has been minimized.

bors commented Jun 4, 2021

csmoe commented Jun 8, 2021

jackh726 Jul 3, 2021 • edited Loading

Choose a reason for hiding this comment

jackh726 Jul 3, 2021

Choose a reason for hiding this comment

bors commented Jul 26, 2021

JohnCSimon commented Sep 13, 2021

nikomatsakis commented Sep 15, 2021

nikomatsakis commented Sep 15, 2021

csmoe commented Sep 24, 2021 • edited Loading

nikomatsakis commented Sep 30, 2021

nikomatsakis left a comment

Choose a reason for hiding this comment

This comment has been minimized.

bors commented Oct 8, 2021

This comment has been minimized.

This comment has been minimized.

bors commented Nov 9, 2021

rust-log-analyzer commented Nov 14, 2021

bors commented Nov 28, 2021

crlf0710 commented Dec 17, 2021

Dylan-DPC commented Feb 22, 2022

csmoe commented May 19, 2021 •

edited

Loading

jackh726 Jul 3, 2021 •

edited

Loading

csmoe commented Sep 24, 2021 •

edited

Loading