Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deal with const_evaluatable_checked in ConstEquate #85481

Merged
merged 1 commit into from
May 25, 2021
Merged

deal with const_evaluatable_checked in ConstEquate #85481

merged 1 commit into from
May 25, 2021

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 19, 2021

Failing to evaluate two constants which do not contain inference variables should not result in ambiguity.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2021
@lcnr lcnr added A-const-generics Area: const generics (parameters and arguments) F-generic_const_exprs `#![feature(generic_const_exprs)]` labels May 19, 2021
@matthewjasper
Copy link
Contributor

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented May 25, 2021

📌 Commit 412e040 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2021
@bors
Copy link
Contributor

bors commented May 25, 2021

⌛ Testing commit 412e040 with merge ff2c947...

@bors
Copy link
Contributor

bors commented May 25, 2021

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing ff2c947 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 25, 2021
@bors bors merged commit ff2c947 into rust-lang:master May 25, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 25, 2021
@lcnr lcnr deleted the const-equate branch June 21, 2021 10:20
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
A-const-generics Area: const generics (parameters and arguments) F-generic_const_exprs `#![feature(generic_const_exprs)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @rust-highfive @matthewjasper @bors @rustbot