Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vxworks #85490

Merged
merged 2 commits into from
May 23, 2021
Merged

Fix vxworks #85490

merged 2 commits into from
May 23, 2021

Conversation

CDirkx
Copy link
Contributor

@CDirkx CDirkx commented May 19, 2021

Some PRs made the vxworks target not build anymore. This PR fixes that:

@rust-highfive
Copy link
Collaborator

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2021
@dtolnay
Copy link
Member

dtolnay commented May 20, 2021

@bors r+

@bors
Copy link
Contributor

bors commented May 20, 2021

📌 Commit 03e90b7 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2021
@bors
Copy link
Contributor

bors commented May 21, 2021

⌛ Testing commit 03e90b7 with merge 426172fc422fd938952ac69241d91ace4cf470de...

@bors
Copy link
Contributor

bors commented May 22, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 22, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@CDirkx
Copy link
Contributor Author

CDirkx commented May 23, 2021

Tests timed out, seems not related to this PR. (vxworks is a tier 3 target and not tested, so nothing that the CI runs has changed)

@dtolnay
Copy link
Member

dtolnay commented May 23, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2021
@bors
Copy link
Contributor

bors commented May 23, 2021

⌛ Testing commit 03e90b7 with merge 6e92fb4...

@bors
Copy link
Contributor

bors commented May 23, 2021

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 6e92fb4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 23, 2021
@bors bors merged commit 6e92fb4 into rust-lang:master May 23, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 23, 2021
@CDirkx CDirkx deleted the fix-vxworks branch May 23, 2021 13:59
@dtolnay dtolnay assigned dtolnay and unassigned yaahc Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
7 participants
@CDirkx @rust-highfive @dtolnay @bors @rust-log-analyzer @yaahc @rustbot