Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide inherent implementations by default #85602

Merged
merged 1 commit into from
May 23, 2021

Conversation

GuillaumeGomez
Copy link
Member

Fixes a regression introduced in #85575.

r? @jsha

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 23, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2021
@GuillaumeGomez GuillaumeGomez added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label May 23, 2021
@jsha
Copy link
Contributor

jsha commented May 23, 2021

Thanks for the quick fix, and sorry for the regression.

@bors r+

@bors
Copy link
Contributor

bors commented May 23, 2021

📌 Commit d7579b9 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2021
@GuillaumeGomez
Copy link
Member Author

Since it's a regression fix, let's increase the priority a bit.

@bors: p=1

@bors
Copy link
Contributor

bors commented May 23, 2021

⌛ Testing commit d7579b9 with merge d8af907...

@bors
Copy link
Contributor

bors commented May 23, 2021

☀️ Test successful - checks-actions
Approved by: jsha
Pushing d8af907 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 23, 2021
@bors bors merged commit d8af907 into rust-lang:master May 23, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 23, 2021
@GuillaumeGomez GuillaumeGomez deleted the donthide-inherent-impls branch May 23, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants