-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #85838
Rollup of 8 pull requests #85838
Commits on May 27, 2021
-
Do not try to build LLVM with Zlib on Windows
We do not install Zlib on the CI but recent builds somehow started picking it's shared version. To avoid relying on CI binaries so let's explicitly disable it.
Configuration menu - View commit details
-
Copy full SHA for 53bf79e - Browse repository at this point
Copy the full SHA 53bf79eView commit details
Commits on May 28, 2021
-
Remove
--print unversioned-files
from rustdocThis flag isn't needed anymore. See rust-lang#83784.
Configuration menu - View commit details
-
Copy full SHA for 8b6dad2 - Browse repository at this point
Copy the full SHA 8b6dad2View commit details
Commits on May 29, 2021
-
Add
String::extend_from_within
This patch adds `String::extend_from_within` function under the `string_extend_from_within` feature gate similar to the `Vec::extend_from_within` function.
Configuration menu - View commit details
-
Copy full SHA for 23f9b92 - Browse repository at this point
Copy the full SHA 23f9b92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f1372b - Browse repository at this point
Copy the full SHA 2f1372bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa1b127 - Browse repository at this point
Copy the full SHA aa1b127View commit details -
Use correct edition when parsing
:pat
matchersAs described in issue rust-lang#85708, we currently do not properly decode `SyntaxContext::root()` and `ExpnId::root()` from foreign crates. As a result, when we decode a span from a foreign crate with `SyntaxContext::root()`, we end up up considering it to have the edition of the *current* crate, instead of the foreign crate where it was originally created. A full fix for this issue will be a fairly significant undertaking. Fortunately, it's possible to implement a partial fix, which gives us the correct edition-dependent behavior for `:pat` matchers when the macro is loaded from another crate. Since we have the edition of the macro's defining crate available, we can 'recover' from seeing a `SyntaxContext::root()` and use the edition of the macro's defining crate. Any solution to issue rust-lang#85708 must reproduce the behavior of this targeted fix - properly preserving a foreign `SyntaxContext::root()` means (among other things) preserving its edition, which by definition is the edition of the foreign crate itself. Therefore, this fix moves us closer to the correct overall solution, and does not expose any new incorrect behavior to macros.
Configuration menu - View commit details
-
Copy full SHA for d874ecc - Browse repository at this point
Copy the full SHA d874eccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d70f40 - Browse repository at this point
Copy the full SHA 8d70f40View commit details -
Configuration menu - View commit details
-
Copy full SHA for b237f90 - Browse repository at this point
Copy the full SHA b237f90View commit details
Commits on May 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b4148e9 - Browse repository at this point
Copy the full SHA b4148e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 558b073 - Browse repository at this point
Copy the full SHA 558b073View commit details -
Rollup merge of rust-lang#85285 - GuillaumeGomez:eslint-check, r=jsha…
…,Mark-Simulacrum Add eslint checks to CI It also allowed me to fix some potential issues that went unnoticed. Having this process automated will hopefully prevent us to add more errors. :) cc `@Mark-Simulacrum` (for the add in the CI). r? `@jsha`
Configuration menu - View commit details
-
Copy full SHA for 9c873c1 - Browse repository at this point
Copy the full SHA 9c873c1View commit details -
Rollup merge of rust-lang#85709 - Aaron1011:fix-pat-crate-edition, r=…
…petrochenkov Use correct edition when parsing `:pat` matchers As described in issue rust-lang#85708, we currently do not properly decode `SyntaxContext::root()` and `ExpnId::root()` from foreign crates. As a result, when we decode a span from a foreign crate with `SyntaxContext::root()`, we end up up considering it to have the edition of the *current* crate, instead of the foreign crate where it was originally created. A full fix for this issue will be a fairly significant undertaking. Fortunately, it's possible to implement a partial fix, which gives us the correct edition-dependent behavior for `:pat` matchers when the macro is loaded from another crate. Since we have the edition of the macro's defining crate available, we can 'recover' from seeing a `SyntaxContext::root()` and use the edition of the macro's defining crate. Any solution to issue rust-lang#85708 must reproduce the behavior of this targeted fix - properly preserving a foreign `SyntaxContext::root()` means (among other things) preserving its edition, which by definition is the edition of the foreign crate itself. Therefore, this fix moves us closer to the correct overall solution, and does not expose any new incorrect behavior to macros.
Configuration menu - View commit details
-
Copy full SHA for bdd7062 - Browse repository at this point
Copy the full SHA bdd7062View commit details -
Rollup merge of rust-lang#85762 - mati865:disable-zlib-on-windows, r=…
…Mark-Simulacrum Do not try to build LLVM with Zlib on Windows Fixes rust-lang#85422 Fixes rust-lang#85624 We do not install Zlib on the CI but recent builds somehow started picking it's shared version. To avoid relying on CI binaries so let's explicitly disable it.
Configuration menu - View commit details
-
Copy full SHA for 957badb - Browse repository at this point
Copy the full SHA 957badbView commit details -
Rollup merge of rust-lang#85770 - Bobo1239:set_locale_for_sort, r=jyn514
Remove `--print unversioned-files` from rustdoc This flag isn't needed anymore. See rust-lang#83784.
Configuration menu - View commit details
-
Copy full SHA for f7fb29b - Browse repository at this point
Copy the full SHA f7fb29bView commit details -
Rollup merge of rust-lang#85781 - badboy:document-aarch-ios-sim-suppo…
…rt, r=Amanieu Add documentation for aarch64-apple-ios-sim target Documentation as requested for [MCP 428](rust-lang/compiler-team#428) to promote this target to Tier 2. Currently it calls out that it's Tier 3. That should be changed if this target is promoted, but this PR could also land before that. Note: probably should get signoff from the compiler team based on that MCP.
Configuration menu - View commit details
-
Copy full SHA for 2d30bc7 - Browse repository at this point
Copy the full SHA 2d30bc7View commit details -
Rollup merge of rust-lang#85801 - WaffleLapkin:master, r=joshtriplett
Add `String::extend_from_within` This PR adds `String::extend_from_within` function under the `string_extend_from_within` feature gate similar to the [`Vec::extend_from_within`] function. ```rust // String pub fn extend_from_within<R>(&mut self, src: R) where R: RangeBounds<usize>; ``` [`Vec::extend_from_within`]: rust-lang#81656
Configuration menu - View commit details
-
Copy full SHA for b0f2a4c - Browse repository at this point
Copy the full SHA b0f2a4cView commit details -
Rollup merge of rust-lang#85817 - r00ster91:patch-9, r=dtolnay
Fix a typo See also: rust-lang#85737
Configuration menu - View commit details
-
Copy full SHA for 980a4a7 - Browse repository at this point
Copy the full SHA 980a4a7View commit details -
Rollup merge of rust-lang#85818 - LeSeulArtichaut:85794-diag-drop-ice…
…, r=petrochenkov Don't drop `PResult` without handling the error Fixes rust-lang#85794.
Configuration menu - View commit details
-
Copy full SHA for 71a7f8f - Browse repository at this point
Copy the full SHA 71a7f8fView commit details