Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions and arguments from rustc_serialize #85903

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jun 1, 2021

No description provided.

@bjorn3 bjorn3 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 1, 2021
@rust-highfive
Copy link
Contributor

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2021
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 1, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2021
@bors
Copy link
Collaborator

bors commented Jun 1, 2021

⌛ Trying commit a2c4aff with merge ac0b59d6d4be322e6627f407ad70bef62ff5492a...

@bors
Copy link
Collaborator

bors commented Jun 1, 2021

☀️ Try build successful - checks-actions
Build commit: ac0b59d6d4be322e6627f407ad70bef62ff5492a (ac0b59d6d4be322e6627f407ad70bef62ff5492a)

@rust-timer
Copy link
Collaborator

Queued ac0b59d6d4be322e6627f407ad70bef62ff5492a with parent 7f9ab03, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (ac0b59d6d4be322e6627f407ad70bef62ff5492a): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2021
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 2, 2021

Mostly improvements up to 1.5%. A few small regressions up to 0.4%.

@varkor
Copy link
Member

varkor commented Jun 6, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 6, 2021

📌 Commit a2c4aff has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2021
@bors
Copy link
Collaborator

bors commented Jun 7, 2021

⌛ Testing commit a2c4aff with merge e4a6032...

@bors
Copy link
Collaborator

bors commented Jun 7, 2021

☀️ Test successful - checks-actions
Approved by: varkor
Pushing e4a6032 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2021
@bors bors merged commit e4a6032 into rust-lang:master Jun 7, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 7, 2021
@bjorn3 bjorn3 deleted the rustc_serialize_cleanup branch June 7, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants