Add/modify iterator size_hint()s #8604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When PR #8582 lands, |
| @@ -1504,6 +1522,9 @@ impl<A: Add<A, A> + Ord + Clone> Iterator<A> for Range<A> { | |||
| None | |||
| } | |||
| } | |||
|
|
|||
| // FIXME: Implement size_hint() | |||
There was a problem hiding this comment.
I think tidy.py will yell about this, need to make an issue and add the number.
There was a problem hiding this comment.
Oh damn, so it does. I didn't realize.
Add size_hint() to a few Iterators that were missing it. Update a couple of existing size_hint()s to use checked_add() instead of saturating_add() for the upper bound.
| if self.v.len() == 0 { | ||
| (0, Some(0)) | ||
| } else { | ||
| let (n, rem) = self.v.len().div_rem(&self.size); |
There was a problem hiding this comment.
will this handle size == 0 properly? or do we not wind up in this iterator in this case?
There was a problem hiding this comment.
chunk_iter() has assert!(size != 0).
bors
added a commit
that referenced
this pull request
Aug 21, 2013
Implement `size_hint()` on the new std::vec Iterators. Add or update `size_hint()` on std::iterator Iterators where appropriate. r? @thestinger
xFrednet
pushed a commit
to xFrednet/rust
that referenced
this pull request
May 21, 2022
…r=Alexendoo Fix redundant_allocation warning for Rc<Box<str>> changelog: [`redundant_allocation`] Fixes rust-lang#8604 Fixes false positives where a fat pointer with `str` type was made thin by another allocation, but that thinning allocation was marked as redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
size_hint()on the new std::vec Iterators.Add or update
size_hint()on std::iterator Iterators where appropriate.r? @thestinger