-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix display for search results #86040
Fix display for search results #86040
Conversation
Some changes occurred in HTML/CSS/JS. |
@bors r+ rollup Thanks for the fix! As a followup, it would be nice to change the class names for search result entries so they're not the same as class names used in the document body. For instance these could become |
📌 Commit c01bd56 has been approved by |
The advantage of the current situation is that we use the same colors (which is why we re-used the class in the first place). |
This doesn't fix: (See the top/bottom margin for type def items) It looks like the problem is inherent to the elimination of I'd imagine that we should've applied these rules with more precision like we did with rust/src/librustdoc/html/static/rustdoc.css Lines 140 to 148 in 86b0baf
|
I never said it fixes the bold text, I said it fixes the margin on the search results. |
Sorry, I didn't even notice the PR title and assumed that this PR was to fix the top/bottom margin issue. However, my points I mentioned still hold imo. |
Yes, but they are completely unrelated to this fix. |
…y-height, r=jsha Fix display for search results This fixes unwanted margin and font-weight coming from `.method`. Before: ![Screenshot from 2021-06-05 23-03-34](https://user-images.githubusercontent.com/3050060/120905486-9e46f380-c652-11eb-8008-6db6e0517ba3.png) after: ![Screenshot from 2021-06-05 23-05-02](https://user-images.githubusercontent.com/3050060/120905489-9edf8a00-c652-11eb-817d-f676f6ab7303.png) r? `@jsha`
…laumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#83433 (Pass --cfg=bootstrap for proc macros built by stage0) - rust-lang#84940 (Don't run sanity checks for `x.py setup`) - rust-lang#85912 (Use `Iterator::any` and `filter_map` instead of open-coding them) - rust-lang#85965 (Remove dead code from `LocalAnalyzer`) - rust-lang#86010 (Fix two ICEs in the parser) - rust-lang#86040 (Fix display for search results) - rust-lang#86058 (Remove `_` from E0121 diagnostic suggestions) - rust-lang#86077 (Fix corrected example in E0759.md) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This fixes unwanted margin and font-weight coming from
.method
. Before:after:
r? @jsha