Add the x86_64-gnu-stable builder #86098
Conversation
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
|
⌛ Trying commit db3b8032b9b02bbbbaad73936fbb28d853d18ebc with merge e6e6ad566431f5235b25806487450ceea90ec514... |
|
@bors try |
|
⌛ Trying commit 97438ae3d5a1087a4184529c5198adcc4ff59f2e with merge 0308500f867a0d7159179cd9f66f66e0f06b967a... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
@bors try |
|
⌛ Trying commit f1982ce649e08b16a49b5e3bb4d769970b2b0d05 with merge 3dc547091ab35053375bf40de567df6db7819869... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
The session-derive-errors test ensures the internal SessionDiagnostic
derive macro outputs the right error messages when misused.
The macro relies on the proc_macro2 crate though, which changes its span
behavior depending on whether the channel is nightly or not. This caused
test failures when bumping the channel from nightly to beta/stable.
Since SessionDiagnostic is internal-only we don't care about its
diagnostics quality outside of nightly, as the compiler itself is
developed on nightly. Thus the easiest solution is to ignore that test
on the beta and stable channels.
This also implements `// only-{channel}` and `// ignore-{channel}` in
compiletest to properly support the change.
|
@bors try |
|
⌛ Trying commit 78b70bc9da3c4735da7bbfa0a05ee6946a94a5a1 with merge 11a59a658ff1c970d5a63e559c67baa9c536e1dd... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
During the 1.52 release process we had to deal with some commits that passed the test suite on the nightly branch but failed on the beta or stable branch. In that case it was due to some UI tests including the channel name in the output, but other changes might also be dependent on the channel. This commit adds a new CI job that runs the Linux x86_64 test suite with the stable branch, ensuring nightly changes also work as stable.
|
@bors try |
|
⌛ Trying commit c7981b390bad3c9961ca09d5aecd5dbf2e5c1977 with merge dce2a5127ffe1878ea2e20443b7ef625e23c35da... |
|
☀️ Try build successful - checks-actions |
|
Ok this should be ready for review. |
pietroalbini
added
S-waiting-on-review
|
This looks OK to me. Hopefully we won't have cases of someone gating behavior on beta vs. stable... @bors r+ rollup=iffy |
|
📌 Commit 12d37e6 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
During the 1.52 release process we had to deal with some commits that passed the test suite on the nightly branch but failed on the beta or stable branch. In that case it was due to some UI tests including the channel name in the output, but other changes might also be dependent on the channel.
This commit adds a new CI job that runs the Linux x86_64 test suite with the stable branch, ensuring nightly changes also work as stable. To ensure the new job works the following other changes are present:
ui-fulldeps/session-derive-errors.rstest has been disabled on beta and stable, which required adding support for// ignore-{channel}and// only-{channel}.rustdoc/intra-doc/field.rshas been fixed.r? @Mark-Simulacrum
fixes rust-lang/release-team#11