Create different inference variables for different defining uses of TAITs #86118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stinct generic parameters
rust-highfive
added
the
S-waiting-on-review
spastorino
commented
Jun 7, 2021
nikomatsakis
approved these changes
Jun 8, 2021
|
@bors r+ |
|
@nikomatsakis: 🔑 Insufficient privileges: Not in reviewers |
|
@rust-lang/infra huh? |
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
tait-soundness-bug
branch
from
813a004 to
f07412d
Compare
nikomatsakis
requested changes
Jun 8, 2021
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
tait-soundness-bug
branch
from
c597be6 to
5590277
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
tait-soundness-bug
branch
from
50246ec to
7b1e1c7
Compare
nikomatsakis
approved these changes
Jun 8, 2021
|
@bors r+ |
|
📌 Commit 7b1e1c7 has been approved by |
bors
added
S-waiting-on-bors
|
This changes used data structures, so should(?) affect perf. |
|
@bors rollup=never I am fairly confident this will not have an effect on perf, but it'd be good for any effect it MAY have to be isolated. |
|
☀️ Test successful - checks-actions |
This was referenced Jun 10, 2021
Closed
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 21, 2021
…acrum Add a regression test for issue-85113 Fixed by rust-lang#86118, closes rust-lang#85113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73481
r? @nikomatsakis
cc @oli-obk